Comments (6)
To resolve the issue where the view becomes blank after deleting a select field, follow these steps:
-
Modify view deletion logic:
- Update the
useViews
,useViewFilters
, anduseViewSorts
hooks to handle the deletion of views when the associated select field is deleted. Ensure that these hooks check for the existence of the select field and remove the corresponding views if the field is deleted.
- Update the
-
Add confirmation window:
- Update the
ViewPickerCreateOrEditContent
andViewPickerCreateOrEditContentEffect
components to include a confirmation window. This window should inform the user about the views that will be removed when the select field is deleted.
- Update the
Example code snippets:
useViews.js:
// Add logic to delete views associated with the deleted select field
useEffect(() => {
if (deletedSelectField) {
const updatedViews = views.filter(view => view.fieldId !== deletedSelectField.id);
setViews(updatedViews);
}
}, [deletedSelectField]);
ViewPickerCreateOrEditContent.js:
// Add confirmation window logic
const handleDeleteSelectField = (fieldId) => {
const affectedViews = views.filter(view => view.fieldId === fieldId);
if (affectedViews.length > 0) {
if (window.confirm(`Deleting this field will remove ${affectedViews.length} views. Do you want to proceed?`)) {
deleteSelectField(fieldId);
}
} else {
deleteSelectField(fieldId);
}
};
Ensure these changes are integrated into the respective files and tested for the described scenario.
References
from twenty.
@Weiko #6028 may be related to this one too if you have any inputs?
from twenty.
The mentioned issue will be the next impact if this is not addressed/fixed
After this object field deletion and navigate back to view again
from twenty.
@Bonapara is it ok to delete the view directly when deleting the field, or should we add a modal when deleting the field to warn that the view will be deleted ?
from twenty.
We can delete it directly, at least for now!
from twenty.
Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6027
from twenty.
Related Issues (20)
- Existing user of one workspace doesn't have transferred data when invited to another workspace HOT 1
- Demo link not working
- Field "body" on Create note and task API creates error HOT 2
- Cache related error after upgrading from 0.22.0 to 0.23.1 HOT 1
- Change defaultHomePagePath from /objects/companies to last visited page HOT 8
- Ex: In DarkMode, a blank square appears in bottom right corner while scrolling HOT 2
- Modify event emitter to emit an array of events
- In Search, redirect 'Create Task' doesn't work HOT 1
- After creating new object or clicking 'c', global redirect shortcuts don't work
- Visualisation of relations between objects doesn't work
- Creating empty objects HOT 3
- Editing empty name of Company HOT 2
- Try WebPack on twenty-front
- Create an e2e test for login HOT 1
- E2E testing should be able to query the DB to work on actual data and not hard coded mocks. HOT 1
- No login page after changes introduced in #6621
- REST API returns 500 error code when request is sent with wrong key HOT 1
- Introduction to E2E Playwright testing HOT 2
- Update AWS SDK to v3
- Docker failing to start - new installation - Container twenty-server-1: Error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twenty.