Giter Club home page Giter Club logo

Comments (6)

i-am-chitti avatar i-am-chitti commented on May 23, 2024 1

Thanks @FelixMalfait and @lucasbordeau for the notes.
I've started working on this.

from twenty.

i-am-chitti avatar i-am-chitti commented on May 23, 2024

Hi @FelixMalfait,
I'm interested in working on this. Please have a review of below notes to be on same page -

      <Helmet>
        <script
          src="https://www.google.com/recaptcha/api.js?render=6Le-alYpAAAAAEW_lYoHgrVofgdZRfeLjU4TcjtJ"
          async
          defer
        ></script>
      </Helmet>

To make it driver driven, I'll be taking inspiration from existing drivers like SMTP for email.

One doubt though -

  • By Google invisible recaptcha, I think you're referring to v3, right?

from twenty.

FelixMalfait avatar FelixMalfait commented on May 23, 2024

Legend @i-am-chitti you're everywhere 😅 - thanks!!!

Agree with everything you said. And yes v3.

I just have a doubt on react-helmet, I'm not the most qualified to answer technical questions.
What you suggest seems like a nice and clean approach, actually cleaner than what we do here in my opinion:
https://github.com/twentyhq/twenty/blob/main/packages/twenty-front/src/modules/support/components/SupportChat.tsx
But it would be great to get confirmation from @lucasbordeau

from twenty.

lucasbordeau avatar lucasbordeau commented on May 23, 2024

Current implementation with insertScript seems fine, although we could extract it in an external hook.

from twenty.

FelixMalfait avatar FelixMalfait commented on May 23, 2024

Hey @i-am-chitti let us know if you have questions! I know this isn't a small task and you have other things to do :)

from twenty.

i-am-chitti avatar i-am-chitti commented on May 23, 2024

Hi @FelixMalfait,
The backend is ready and on frontend, I've completed integrating the Google recaptcha. Currently, hCaptcha and Turnstile is pending on frontend.

Didn't get time to work on this past two weeks. Just synced my main branch and found I've lots of merge conflicts. I'm resolving them. Will complete the pending integrations and raise PR in some days.

from twenty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.