Comments (6)
Thanks @FelixMalfait and @lucasbordeau for the notes.
I've started working on this.
from twenty.
Hi @FelixMalfait,
I'm interested in working on this. Please have a review of below notes to be on same page -
- expose an environment variable for which provider to use. This'll also be populated on frontend
clientConfig
so that frontend can conditionally load and use the provider. - The flow can be understood best by - https://docs.hcaptcha.com/#request-flow. This remains same for all three.
- All three provides the programatical invocation. So, once user clicks on 'Submit' button, I'll trigger the execution and get the token or passcode from respective provider.
- We'll require a GQL query endpoint which accepts this token and returns if captcha verification was successful. In its response, display a snackbar of recaptcha failed message and reset the execution so that passcode can be re-generated.
- This GQL query will internally make call to the provider to verify the passcode. Docs can be found here -
- If there is no environment variable present, then, skip the recaptcha validation on frontend.
- To load the script of each provider conditionally, I'll be using the react-helmet-async. This is done only in form component.
<Helmet>
<script
src="https://www.google.com/recaptcha/api.js?render=6Le-alYpAAAAAEW_lYoHgrVofgdZRfeLjU4TcjtJ"
async
defer
></script>
</Helmet>
To make it driver driven, I'll be taking inspiration from existing drivers like SMTP for email.
One doubt though -
- By Google invisible recaptcha, I think you're referring to v3, right?
from twenty.
Legend @i-am-chitti you're everywhere 😅 - thanks!!!
Agree with everything you said. And yes v3.
I just have a doubt on react-helmet, I'm not the most qualified to answer technical questions.
What you suggest seems like a nice and clean approach, actually cleaner than what we do here in my opinion:
https://github.com/twentyhq/twenty/blob/main/packages/twenty-front/src/modules/support/components/SupportChat.tsx
But it would be great to get confirmation from @lucasbordeau
from twenty.
Current implementation with insertScript
seems fine, although we could extract it in an external hook.
from twenty.
Hey @i-am-chitti let us know if you have questions! I know this isn't a small task and you have other things to do :)
from twenty.
Hi @FelixMalfait,
The backend is ready and on frontend, I've completed integrating the Google recaptcha. Currently, hCaptcha and Turnstile is pending on frontend.
Didn't get time to work on this past two weeks. Just synced my main branch and found I've lots of merge conflicts. I'm resolving them. Will complete the pending integrations and raise PR in some days.
from twenty.
Related Issues (20)
- Prevent user-guide content to flash on page change HOT 1
- Forgot password feature broken HOT 1
- Objects: Multi-select: Insert multiple options at once HOT 5
- Modify the partial sync cron to work with the new statuses HOT 1
- Remove Flash on intermediate Verify step when sign In with SSO HOT 1
- Remove Flash on intermediate Verify step when sign Up with SSO or Email/Password HOT 1
- With CSV import, special characters are garbled HOT 1
- Update Docker Hub image HOT 1
- Refresh schema post-impersonation HOT 1
- Provide example on how to create a field. HOT 4
- Coverage is not properly calculated HOT 2
- "Delete" option in Kanban board contextual menu does not delete HOT 3
- When an opportunity is deleted, the related Favorite is not optimistically removed HOT 3
- Fix Captcha when entering a wrong password HOT 1
- /rest/batch/people very slow response when payload incorrect HOT 2
- Fix app flashs HOT 1
- Add support for CZK Currency HOT 1
- Create a new cron FullSyncMessageListFetchCron HOT 1
- Creating a field with a space leads to the app crashing HOT 4
- Add a ⏎ shortcut on Select options HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twenty.