snake_case naming convention support about venflow HOT 8 CLOSED

Sounds good, I'll take a look at getting a PR ready, will get in touch if I have any questions )

from venflow.

Thanks a lot for your contribution, I'll release a new version in a few days including this feature :)

from venflow.

First of all, thanks for your issue and a possible implementation! I have already thought about this in the past and I totally agree with you. However, it would make sense IMO to use the existing INpgsqlNameTranslator that Npgsql already provides. There are already existing implementations even for snake_case, see here. The idea behind the INpgsqlNameTranslator is to be only used for properties/columns. Anyhow I don't see any issue, if we would use it for tables as well.

from venflow.

Also you were already quite right about the direction of your implementation, but instead of just injecting the name translator, lets just inject the whole Database, as this would be more future proof. This would even allow us to register PostgreSQL enums only on a database level, but I can do this afterwards.

from venflow.

Additionally I'd register the INpgsqlNameTranslator through the DatabaseConfigurationOptionsBuilder rather than the DatabaseOptionsBuilder. The DatabaseOptionsBuilder get called every time on instantiation in order to allow for dynamic configuration of those supplied values. DatabaseConfigurationOptionsBuilder on the other hand will only ever be called once, which is enough for the INpgsqlNameTranslator.

from venflow.

If you feel like making those changes and creating a PR, I'd more than appreciate it. If you need any help, let me know.

from venflow.

opened #24

from venflow.

happy to contribute )

from venflow.