closures does not work in system without `unzip` about clodl HOT 7 OPEN

I tried it in centos and it seems to work. To produce the following output, I edited bazel-genfiles/clotestbin-cc-pie.sh as follows:

    #!/usr/bin/env bash
-   set -eu
+   set -eux
    tmpdir=$(mktemp -d)
    trap "rm -rf '$tmpdir'" EXIT
    unzip -q "$0" -d "$tmpdir" 2> /dev/null || true
    "$tmpdir/clotestbin-cc-pie-closure_wrapper"
    exit 0

$ bazel-genfiles/clotestbin-cc-pie.sh
+++ mktemp -d
++ tmpdir=/tmp/tmp.LrouJaUrK4
++ trap 'rm -rf '\''/tmp/tmp.LrouJaUrK4'\''' EXIT
++ unzip -q bazel-genfiles/clotestbin-cc-pie.sh -d /tmp/tmp.LrouJaUrK4
++ true
++ /tmp/tmp.LrouJaUrK4/clotestbin-cc-pie-closure_wrapper
hello cc
++ exit 0
++ rm -rf /tmp/tmp.LrouJaUrK4

If the script can't find /tmp/tmp.LrouJaUrK4/clotestbin-cc-pie-closure_wrapper as it says, the most likely cause is that unzip -q bazel-genfiles/clotestbin-cc-pie.sh -d /tmp/tmp.LrouJaUrK4 doesn't output the files where we expect.

from clodl.

You are right. That's just the missing unzip. I'm changing the title to reflact that clodl closures are not working on system without unzip.

from clodl.

Sounds good. Do you have any proposals for a fix?

We could check if unzip is present and produce a better error message. Is this what you expect?

from clodl.

It would be better yes.

Why using unzip? Isn't tar or gunzip more portable? I've tested on docker containers, tar and gunzip are always present in ubuntu, debian, arch, centos and nixos. However unzip was not present in any of the docker image I pulled for theses distributions.

from clodl.

from clodl.

Clodl uses zip, the same as jars. But we never use clodl to build a jar. At least sparkle creates the jars using java_library, not clodl.

@guibou if you need another format, it could be added as an option. If you want to eliminate zip, then we would need to teach sparkle to extract the new format, but it is probably not worth the trouble.

from clodl.

Having clodl output tar archives would be really handy when using it to build containers since the container_image rule from rules_docker can directly take a tgz as input.
Atm the way I use it is that I have a genrule which unzip the clodl-generated archive and re-packs it with tar, but that's far from optimal

from clodl.