TODO about icons HOT 16 CLOSED

Netlify has been enabled for this repo. You should be able to setup the right build process whenever we're ready.

from icons.

@mdo would be easier for me if I actually had access to the Netlify project (same for the other projects BTW). Right now I can't see why it fails nor change any settings.

from icons.

You should have permissions on Netlify now. I setup a few things after comparing against Bootstrap's main repo, but might need more help.

from icons.

Cool, I'll check it out later or tomorrow morning.

How are we going to do production deployments? Via Actions CI or are we going to use Netlify?

from icons.

BTW the failures are normal due to the symlink. All this will be fixed in the Hugo branch. Maybe I should merge it for now so that we can move on?

from icons.

Working on new Actions access for other repos—I'd like to use that for our deployments. I know we can trigger events on either tag/release, so we could do that and kickoff the workflow for a push to the gh-pages branch.

from icons.

Going to want to document some stuff around SVGs:

• https://stackoverflow.com/questions/18467982/are-svg-parameters-such-as-xmlns-and-version-needed

from icons.

Split the todos and removed some. Much of this isn't a blocker IMO—this is intended to be an alpha release, so there's absolutely no rush to do everything in a particular way at all.

from icons.

Updated. After we have Actions CI we can proceed with automating more stuff.

from icons.

Updated. We should really stop inlining the icons. We might need to do some lazyloading though, we'll see how it goes in a PR which will tackle this.

from icons.

We should really stop inlining the icons.

This is a pretty common practice with SVGs (including with GitHub). What are the disadvantages other than file size of the page? Advantages I know are that it allows currentColor usage and it allows folks to inspect and copy the code.

from icons.

We can inline them when we need to, but currently the HTML size has gone like ~180 KB. If we keep adding more and more icons everything will be sluggier because there's just too many DOM elements.

from icons.

Maybe we can load them using XMLHttpRequest?

from icons.

Not sure if this would help a lot. Neither lazyloading, although it should help.

Maybe we should see how other icon libraries with many icons do it?

from icons.

This is something to consider along with dropping width/height https://codesandbox.io/s/scale-svg-icon-with-font-size-u88nz

With width and height, the SVG is not responsive by default, it will just use the dimensions set up there IIRC.

from icons.

@mdo should we close this issue now?

from icons.