iOS private mode: Missing check for tus.isSupported. about tus-js-client HOT 8 CLOSED

Intentionally, isSupported may be true even if local storage is not available. The reason is that it should indicate whether tus-js-client can upload at all which requires file slicing and support for XHR but no Web Storage. If you are interested in whether it is able to store URLs in the local storage, you have to examine canStoreURLs (see https://github.com/tus/tus-js-client#tuscanstoreurls).

from tus-js-client.

I see, I wasn't aware of canStoreURLs.

However I'm not sure the private mode on Safari on iOS really sets the canStoreURLs to false: if I'm not mistaken, tus is only checking whether the local storage exists, but not whether it's accepting any values.

Local storage exists in private mode, but it's not accepting any values and throws a QuotaExceededError when attempting to actually save values, see this thread. It's a strange behaviour.

from tus-js-client.

The modernizr's approach handles this issue.

function lsTest () {
  var test = 'test';
  try {
    localStorage.setItem(test, test);
    localStorage.removeItem(test);
    return true;
  } catch(e) {
    return false;
  }
}

if (lsTest () === true) {
    // available
} else {
    // unavailable
}

from tus-js-client.

However I'm not sure the private mode on Safari on iOS really sets the canStoreURLs to false: if I'm not mistaken, tus is only checking whether the local storage exists, but not whether it's accepting any values.

In the past, this check has served us well in detecting whether local storage is usable, as accessing the length of it is usually not permitted if the entire Web Storage is unavailable. However, this may not be the case in Safari's private mode. I will take a look at it but this may take some time as I do not have an iOS device at hand.

from tus-js-client.

@Acconut If you like you can assign this issue to me, I'm working on a project right now which involves tus and iOS devices. As far as my company is concerned, working on tus is considered as working on the product.

from tus-js-client.

@mmathys That would be very helpful if you could look into this. Thank you and your company already in advance.

from tus-js-client.

Closing in favor of #53.

from tus-js-client.

The according patch is available in v1.4.2.

from tus-js-client.