Giter Club home page Giter Club logo

Comments (6)

rikhuijzer avatar rikhuijzer commented on July 30, 2024 1

@yebai I won't be able to pick that up in the near future unfortunately

from libtask.jl.

yebai avatar yebai commented on July 30, 2024

After #129 is complete, we can depreciate all T* data structures, and create a switch for enabling _binding_copy for all Julia types.

from libtask.jl.

yebai avatar yebai commented on July 30, 2024

@rikhuijzer would you like to give it another go to depreciate all the TArray and TRef data structures? The new tape_copy API now allows us to copy objects of any user-specified types.

from libtask.jl.

yebai avatar yebai commented on July 30, 2024

@KDr2 let's create a PR to depreciate all the TArray / TRef APIs, and suggest to the user to use Array and Ref as a replacement. Then we can switch on deep-copying behaviour for Array and Ref types by default.

from libtask.jl.

yebai avatar yebai commented on July 30, 2024

Then we can switch on deep-copying behavior for Array and Ref types by default.

For backward compatibility, e.g. this example in README, maybe we can consider a keyword argument to the TapedTask constructor, i.e.

# Default option: when `deepcopy` is empty, then we don't perform deep copy for any types
TapedTask(...; deepcopy=[])

# Switch on deep copy behavior for Array, Dict, Ref
#  Need to update AdvancedPS to explicitly specify `deepcopy` 
TapedTask(...; deepcopy=[Array, Dict, Ref])


# In order to implement `tape_copy` for this design, we might need to 
#  dispatch on `TapedTask` instances, e.g. 

tape_copy(Val{tapedtask}, ...)

from libtask.jl.

KDr2 avatar KDr2 commented on July 30, 2024

a keyword argument to the TapedTask constructor

If we do this, we should add the same argument to TapedFunction and tape_copy? if so, it's not very clean I think.

tape_copy(Val{tapedtask}, ...)

I don't understand this, now we only tape_copy values in bindings.

from libtask.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.