Comments (1)
Hey, thanks for the code review. That's very constructive feedback.
I agree with you on that the HallHandler would be better off in the filehandling package. That was my original thought but for some reason I decided otherwise. I'm moving it there thanks to your suggestion.
I also agree that checking for the correct input in multiple places is unnecessary. I kind of just left it there for now but it's good to be reminded of it.
I think at least most of the private one line long methods are good to have. They abstract the actions to be more easily understandable. For example in the HallParser class the if statement 'if (line.contains("seats in a row"))' wouldn't tell much about it: what's the purpose behind the check? But if the statement is instead 'if (lineIsTheLastNeededForAHall(String line)), it's a lot more understandable. Not seeing the direct implementation right there (other than by going to the method) doesn't matter as the method's name immediately tells anyone looking at the code what it's really trying to check.
I'll check out that there aren't any unnecessary such methods though and will be more very mindful about it in the future. At least that readFile() method in the HallRemover might be quite unnecessary indeed as it just has 'hallParser.readFile();' inside it.
Thanks again!
from movie-theater-seat-service.
Related Issues (3)
- Koodikatselmointi HOT 1
- Koodikatselmointi 2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from movie-theater-seat-service.