Koodikatselmointi about movie-theater-seat-service HOT 1 OPEN

Hey, thanks for the code review. That's very constructive feedback.

I agree with you on that the HallHandler would be better off in the filehandling package. That was my original thought but for some reason I decided otherwise. I'm moving it there thanks to your suggestion.

I also agree that checking for the correct input in multiple places is unnecessary. I kind of just left it there for now but it's good to be reminded of it.

I think at least most of the private one line long methods are good to have. They abstract the actions to be more easily understandable. For example in the HallParser class the if statement 'if (line.contains("seats in a row"))' wouldn't tell much about it: what's the purpose behind the check? But if the statement is instead 'if (lineIsTheLastNeededForAHall(String line)), it's a lot more understandable. Not seeing the direct implementation right there (other than by going to the method) doesn't matter as the method's name immediately tells anyone looking at the code what it's really trying to check.
I'll check out that there aren't any unnecessary such methods though and will be more very mindful about it in the future. At least that readFile() method in the HallRemover might be quite unnecessary indeed as it just has 'hallParser.readFile();' inside it.

Thanks again!

from movie-theater-seat-service.