Giter Club home page Giter Club logo

Comments (8)

WiredUK avatar WiredUK commented on August 12, 2024 1

@kodewdle This is my talent build:

CIQAJSbRac/22NxZbHdYKOQzcMwYGDAAAAAAAAAAAAwMsNGzYWmNmZmZ2mZmF4B2YmZmxsxAjxMmFz2UzMYBmBAAAAAA

image

from elvui.

kodewdle avatar kodewdle commented on August 12, 2024

post talent page

from elvui.

HerrNirmas avatar HerrNirmas commented on August 12, 2024

Same for Hunter Range seem 10m to short

from elvui.

WiredUK avatar WiredUK commented on August 12, 2024

@HerrNirmas Yes, same on my hunter too. Also confirmed on a warlock and a MoP Remix druid.

from elvui.

WiredUK avatar WiredUK commented on August 12, 2024

I think I have figured out the problem. In ElvUI_Libraries/Core/LibRangeCheck-3.0/LibRangeCheck on line 86 we have this line:

local GetSpellBookItemName = _G.GetSpellBookItemName or function(index, bookType)

If I change it to be this, the range check works:

local GetSpellBookItemName = function(index, bookType)

So it seems as if something else is setting up _G.GetSpellBookItemName to do something different.

Also, the official repo for LibRangeCheck seems to have some very different code in there now, so perhaps this is as simple as updating to the latest version.

EDIT: I can confirm that replacing the local lib with the version from the original, minor version 21, (and renaming to "LibRangeCheck-3.0-ElvUI" of course) also fixes this problem too.

from elvui.

kodewdle avatar kodewdle commented on August 12, 2024

Thanks @WiredUK we actually have a fork of thiers, there was an update to theirs again (WeakAuras/LibRangeCheck-3.0@7c73357) which we accounted for (ed65ca4) and fixed a bug in dev (a888856). please retry and report back :)

dev version: elvui-main.zip

from elvui.

WiredUK avatar WiredUK commented on August 12, 2024

dev version: elvui-main.zip

Works great, thanks @kodewdle

from elvui.

kodewdle avatar kodewdle commented on August 12, 2024

fixed in 13.73

from elvui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.