Giter Club home page Giter Club logo

Comments (8)

anagpuyol avatar anagpuyol commented on July 29, 2024

Never mind, I got that to work, but the joints come out with no dyn label assigned
image

from dynamosap.

anagpuyol avatar anagpuyol commented on July 29, 2024

Also, when I pass the frames and the joints together I get the duplicate warning in the collector

from dynamosap.

anagpuyol avatar anagpuyol commented on July 29, 2024

and they are missing in SAP

from dynamosap.

anagpuyol avatar anagpuyol commented on July 29, 2024

General discussion here:

For frames, we have been creating a new label when the load is set, as seen below. I think we should keep the same label and run the checkDuplicates method inside the collector. If the elements have different labels, we can't know if they are the same one, and thus the user might input the same element twice. I am exemplifying this on joints, where both are dyn_0.

Now, there is a bug in the creation of the IDs, which starts from zero on both joints and frames. We could add a prefix for the type of element: dyn_frm_0, dyn_joint_0, dyn_cable_0, dyn_shell_0 or keep track of all them in the trace cache. I like having a different label because one can easily check in the list what type of elements they are, but I also see how just "dyn_" is very clean. Thoughts @bhowes-tt @eertugrul ?

image

from dynamosap.

eertugrul avatar eertugrul commented on July 29, 2024

yes I agree with u for the first part, we have just talked, we are creating a new member but we are passing the label then we check the duplicated items at Collector node.

I set separate Trace mechanisms(TracedManager) for the objects such as Frame, Shell and Joint for now cable will be following next phase. So the labels' string format is the same but this doesn't create any problem on SAP and in Dynamo. The names are unique for each type of structure. Element class has Type enum, each time we create object we pass the appropriate type.

🌹

from dynamosap.

anagpuyol avatar anagpuyol commented on July 29, 2024

This has already been addressed and fixed

from dynamosap.

bhowes-tt avatar bhowes-tt commented on July 29, 2024

I couldn't quite understand the issue during our meeting today, but it sounded like it still needs to be resolved... Assigning @anagpuyol

from dynamosap.

eertugrul avatar eertugrul commented on July 29, 2024

now it is working ! Beware the list should be Flatten list before collector! working now.
image

Thank you

from dynamosap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.