Comments (8)
Hi! I'm currently working on this issue and had a question about the name change. I changed the module name for the en_us and en_gb languages but I was wondering if the scope of this issue includes all other languages in the directory as well. Please let me know and I can change the names for the other languages as well. Thanks!
from corebos.
In general, I try to change as many language files as I can, but my knowledge is limited so I do trust the other language translators to follow the en_us change if they see fit.
I would say, change those that you are fluent in the language. Leave any that you would need google translator :-)
Thank you VERY much for your help!
from corebos.
Thank you for the quick response! The only languages that I am fluent in of the ones in the directory are the ones that I have already changed. Looking through the other languages, I noticed that some only use "Tickets" instead of a translated version of "Trouble Tickets". I don't know if that's intended or if it's because I am not very familiar with the other languages but I just wanted to point it out if it was a mistake.
I have made a pull request at #208. Let me know if it needs any changes!
from corebos.
Hi,
There are more labels than the ones in the two files you changed. I launched a search for "Trouble tickets " in the whole application and about 60 relevant lines came up. Can you please have a look at all of those? If not, let me know.
Thanks!
from corebos.
Let me know if you have doubts about any change.
from corebos.
I'll take a look and get back to you!
from corebos.
Hey so I looked through the instances where "Trouble" appeared in the entire project. I only made modifications to the actual language files and in those only to the actual value and not the key itself. I saw that the database uses strings like "Top Trouble Tickets" to read and write and I felt like those shouldn't be changed at least for now. Also, any comments that used "Trouble" was left as "Trouble" because much of the code refers to the HelpDesk/Tickets as "Trouble Tickets" so I thought that by only changing the visualized values that it would cause as little confusion as possible. Let me know if that was what you had wanted and if not, what other parts I should also look at to resolve the issue. Thanks!
from corebos.
Closed via #208
Thanks!
from corebos.
Related Issues (20)
- Set a row with hidden fields to height = 0 HOT 1
- Advanced search stuck HOT 14
- Impossible to turn off ClickHouse Activation HOT 7
- Upgrade json editor to improve ui for developer :enhancement HOT 2
- workflow "use function" button on workflow condition not working HOT 25
- TUI grid inline edit does not respect currency format
- Zebra_Session: No MySQL connection vendor/stefangabos/zebra_session/Zebra_Session.php:334 HOT 2
- Settings for auto numbering give database error HOT 4
- xss vulnerability
- taxclass values don't show on products filters HOT 2
- Smtp outgoing server and individual smtp server
- Quote Email PDF not work after last update coreBOS 8.0 (baf8d5c8420230209) HOT 3
- Disable Sendgrid detailview email fields by adding global variable... set default disabled #enhancement HOT 4
- Listview details Fields overlap HOT 1
- Send Individual Emails not works in Campaing HOT 1
- Campaign -> Contact Status not work HOT 2
- Bypass check length at Add Folder feature lead to XSS vulnerability in module=evvtgendoc HOT 1
- To Do Activity Type Email non editable HOT 2
- popup list lookup HOT 2
- xampp 7.4 on windows cann't import module HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from corebos.