Giter Club home page Giter Club logo

Comments (8)

jsjqian avatar jsjqian commented on May 27, 2024

Hi! I'm currently working on this issue and had a question about the name change. I changed the module name for the en_us and en_gb languages but I was wondering if the scope of this issue includes all other languages in the directory as well. Please let me know and I can change the names for the other languages as well. Thanks!

from corebos.

joebordes avatar joebordes commented on May 27, 2024

In general, I try to change as many language files as I can, but my knowledge is limited so I do trust the other language translators to follow the en_us change if they see fit.

I would say, change those that you are fluent in the language. Leave any that you would need google translator :-)

Thank you VERY much for your help!

from corebos.

jsjqian avatar jsjqian commented on May 27, 2024

Thank you for the quick response! The only languages that I am fluent in of the ones in the directory are the ones that I have already changed. Looking through the other languages, I noticed that some only use "Tickets" instead of a translated version of "Trouble Tickets". I don't know if that's intended or if it's because I am not very familiar with the other languages but I just wanted to point it out if it was a mistake.

I have made a pull request at #208. Let me know if it needs any changes!

from corebos.

joebordes avatar joebordes commented on May 27, 2024

Hi,

There are more labels than the ones in the two files you changed. I launched a search for "Trouble tickets " in the whole application and about 60 relevant lines came up. Can you please have a look at all of those? If not, let me know.

Thanks!

from corebos.

joebordes avatar joebordes commented on May 27, 2024

Let me know if you have doubts about any change.

from corebos.

jsjqian avatar jsjqian commented on May 27, 2024

I'll take a look and get back to you!

from corebos.

jsjqian avatar jsjqian commented on May 27, 2024

Hey so I looked through the instances where "Trouble" appeared in the entire project. I only made modifications to the actual language files and in those only to the actual value and not the key itself. I saw that the database uses strings like "Top Trouble Tickets" to read and write and I felt like those shouldn't be changed at least for now. Also, any comments that used "Trouble" was left as "Trouble" because much of the code refers to the HelpDesk/Tickets as "Trouble Tickets" so I thought that by only changing the visualized values that it would cause as little confusion as possible. Let me know if that was what you had wanted and if not, what other parts I should also look at to resolve the issue. Thanks!

from corebos.

joebordes avatar joebordes commented on May 27, 2024

Closed via #208
Thanks!

from corebos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.