Image upload "haunted" markdown about ghost HOT 5 CLOSED

Thought I'd try and get some Regex on the go for this, jut for reference (it might be wrong / not efficient).

Find plane image tag, returns $1 for text:

^\n!image\[(.*)\]$

This gets the URL too, returns $1 for text and $2 for URL (check variable $2 to see if URL is set):

^\n!image\[(.*)\]\((.*)\)$

These should work, but not sure as I haven't tested them.

from ghost.

The regex we have so far is:

/\n+!image\[([\d\w\s]*)\]/gi

Which has two problems:

1. it is too greedy with \n and consumes them all breaking things like titles etc
2. It doesn't yet accept the parentheses at the end

The regex lives in core/admin/assets/lib/showdown/extensions/ghostdown.js

from ghost.

Another issue I noticed, (although I feel like I might be missing something) is that the regex doesn't support the shorter image syntax:

![alt](url)

So I'm thinking of something perhaps more like this:

/\n?!(?:image)?\[([^\n\]]*)\](?:\(([^\n\)]*)\))?/gi

I'm submitting a pull request based on this. :)

It looks a bit gross, but the capture-groups are the same, meaning the function arguments can stay readable, without having to include junk parameters just to pad the other arguments out properly.

from ghost.

@ErisDS Doesn't this issue still depend on the actual upload working?

from ghost.

Nope :) this issue was just for the regex which you did.

There are a series of issues for getting uploads working.

• Image Upload: Reusable tool for uploads #280 - a basic uploader tool for Ghost (nearing completion)
• Image Upload: generate IDs in showdown to match with CodeMirror #295 - making it possible to share info about images between showdown/ghost down and CodeMIrror, the hardest part, potentially impossible without modifying code mirror - (no on seems interested)
• Image Upload: Upload in editor panel #40 - wire up the tool/plugin on the editor page
• Image Upload: Save in post - haunted markdown #41 - save the image src back into the markdown

@cobbspur has been working on some of this, but there is still a lot to do

from ghost.