UI refining needed about igniter HOT 18 CLOSED

@Alexinst
I know less about Android UI. Can you help us to refine it?

from igniter.

@oasiscifr Could you explain the task more clearly?

from igniter.

@Alexinst Two features are added recently, introducing a sharelink textEdit and test connection button. At least on my device, they exceed the screen. I think we'd better refine the UI before make a new release.

from igniter.

@oasiscifr I would take a try.

from igniter.

@oasiscifr
Android Virtual Device: Pixel 2 (5.0 inches, 1080 X 1920)

How is this?

from igniter.

@Alexinst Looks far more better!

from igniter.

@oasiscifr Here is the new PR(#71).

from igniter.

@Alexinst Please directly commit to your branch if you have new changes. Don't open a new pull request.

from igniter.

@Alexinst I have committed to my branch before opening a new pull request. And if I don't open a new PR, how do I commit the changes? XD

from igniter.

@Alexinst Your changes to your original branch will show up in the pull request. This is just how it works.

from igniter.

@GreaterFire Sorry, I'm confused now. Should I close the PR(#71)?

from igniter.

@Alexinst Nah. You have opened it just keep it open. Be mindful next time.

from igniter.

@GreaterFire I commit and push my code to my fork repo(alexinst/igniter), and open a new PR to this repo(trojan-gfw/igniter). What's wrong with it, anything that should't be done? XD

from igniter.

@Alexinst I'm interested in why you opened #70 and then closed it and opened #71.

from igniter.

Something new was just committed by wongsyrone. I didn't notice it before I open #70. So, I close #70 and run 'git rebase'. XD

from igniter.

@Alexinst What you should do is, you should rebase your change to master and force push to your branch.

from igniter.

@Alexinst Also, it doesn't really matter if master is newer than you. If you made unrelated changes then the 3-way merger will handle the situation gracefully.

from igniter.

@GreaterFire OK, I see. Thank you!

from igniter.