Suggestions: about usability & visual quality about trois HOT 3 OPEN

Thanks for the suggestions, I will handle this after the heavy typescript refactoring

from trois.

Hi @luan007, typescript refactoring is done :)
About the texture, you need a param so that every texture will use the same encoding ?
Can you explain what you need about convertSRGBToLinear ?

from trois.

@klevron thank you for your efforts..
I'm referring to pmndrs/react-three-fiber#344
or
pmndrs/react-three-fiber@9f98831

basically to get 'good looking & correct looking' images,
users would do:

rndr.toneMapping = THREE.ACESFilmicToneMapping
rndr.outputEncoding = THREE.sRGBEncoding

after which, when using THREE.Texture

tx.encoding = THREE.sRGBEncoding

must be called to ensure correctness of color space, or it would result in visual inconsistencies.

Same logic applies to THREE.Color after tonemap

col.convertSRGBToLinear()

should be called when using tonemapping.

Thus in react-three-fibers, due to being essentially wrapper of three objects, these things can be called 'automatically' upon mount / change, thus I'm thinking if it is possible to do the same in vue context.

Thank you again!

from trois.