Giter Club home page Giter Club logo

Comments (4)

PhilippSalvisberg avatar PhilippSalvisberg commented on May 26, 2024

From my point of view this should be handled by G-1030.

However, PL/SQL Cop does not report a G-1030 for my_date. I consider this a PL/SQL Cop bug. The description of G-1030 should be extended to cover this case as well.

from plsql-and-sql-coding-guidelines.

silviomarghitola avatar silviomarghitola commented on May 26, 2024

G-1030 handles variables that are not used at all. This rule handles variables, that are used (assigned a value), but having assigned a value are no more touched.

from plsql-and-sql-coding-guidelines.

PhilippSalvisberg avatar PhilippSalvisberg commented on May 26, 2024

I know. I'm thinking about, if this case should not be handled by G-1030 as well. The reason is, that the Eclipse IDE does not distinguish between these two cases:

image

from plsql-and-sql-coding-guidelines.

PhilippSalvisberg avatar PhilippSalvisberg commented on May 26, 2024

Based on the discussion in #22 and #40 where we tend to split a rule into multiple rules with clearer meaning and scope, I think now, that it is most probably also a good idea to distinguish between

  • variables that are declared but never used (G-1030)
  • variables that are declared, assigned a value, but never read (this rule)

It will help the developer to more quickly understand what is wrong. And that is a good thing.

from plsql-and-sql-coding-guidelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.