Giter Club home page Giter Club logo

Comments (5)

ptillet avatar ptillet commented on July 22, 2024

Hi :)

The .json file contains the predictor (random forest) to pick the right kernel template to choose given the input shapes. The predictor is trained in $PROJECT_ROOT_DIR/tune/, and serialized into a .json file (to make sure that ISAAC doesn't depend on Python.).

What kind of kernel are you trying to add?

from triton.

listenlink avatar listenlink commented on July 22, 2024

Thanks for your reply. currently we have some fine-tuned kernel of GEMV/GEMM for Intel's graphics, the kernels have some issues:

  1. they may not suitable for all the GEMV/GEMM parameters.
  2. the other is that they may not have good performance for non-Intel platform.
    what is your opinion about the good solution that integrated these kernels into ISAAC?
    add @gongzg into discussion

from triton.

ptillet avatar ptillet commented on July 22, 2024

Oh, yes. I've talked briefly to @gongzg about that. For now I just know that the kernels used intel subgroups extension, which is fine. I have a few questions, so that I can think about integrating them:

Does it work for all sizes of M, N, K (i.e., handles bounds-checking properly) without calling additional "cleanup" kernels?
Does it work for the 4 layouts (NN, NT, TN, TT)?
What are the tunable parameters (how many?). In the current GEMM generator, one parameter ("Depth") is pretty useful for handling "small M, N ; large K" situations. And I'll add another one. We can talk about adding them into your kernel template, if they're not already there.

from triton.

listenlink avatar listenlink commented on July 22, 2024

Hi,
Currently our kernels support al the sizes of M, N, K, but will bring cleanup kernels.
And just work for RowMajor layout currently.
Don't have tunable parameters, but have some different kernels for different usage situation.

from triton.

ptillet avatar ptillet commented on July 22, 2024

That could be interesting :) Is there any place where I can see and/or benchmark the code?

from triton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.