splitAndAdd doesn't move the existing nodes about k-bucket HOT 3 CLOSED

Hi @pafgoncalves ,

Hmm... can you provide an example in code that is not doing what you're expecting? It's been a while, but I took a look at splitAndAdd() and to me it seems it should be doing the right thing (splitting the bucket, moving the nodes to low and high buckets, and then making itself an "inner node" by not having a bucket):

    // redistribute existing contacts amongst the two newly created buckets
    self.bucket.forEach(function (storedContact) {
        if (self.determineBucket(storedContact.id, bitIndex) < 0) {
            self.low.add(storedContact);
        } else {
            self.high.add(storedContact);
        }
    });

    self.bucket = undefined; // mark as inner tree node

from k-bucket.

You are right!
Completely missed the forEach.

from k-bucket.

Ok, cool. Thank you for bringing it up, it's good to have people double-checking the work 😄

from k-bucket.