adding Nushell's syntax about syntect HOT 7 CLOSED

Thanks for the info! 🙏🏻 I still can't work out the mechanic to include a new syntax. e.g. if I search the syntect repo for erlang, I don't find anything...

from syntect.

did you checkout submodules? Erlang is in testdata/Packages/Erlang

from syntect.

I'm not yet convinced it's something we want in syntect as then we'll open the floodgates for requests for getting all sorts of packages added to syntect by default.

Ah gotcha. Yeah, that would quickly become impractical.

Please help me to understand for what reason do you want it in this repository as opposed to in your consumer codebase?

Right, I don't think I've been appreciating how straightforward it would be to just add the nushell schema to my consumer codebase.

Beyond my own immediate use case, my motivation to have the schema included upstream is to help the nushell project become more mainstream, tooling-wise. It's a shame sublimehq/Packages isn't accepting PRs, but it also makes sense. They would be in a similar floodgate position.

I'll close this issue for now. Thanks Keith 🙏🏻 syntect is a tremendous asset to the whole community.

from syntect.

#523 (comment)

I'm curious if the mechanism that includes syntax definitions can source the definition directly from nushell_sublime_syntax, so updates are picked up automatically?

typically syntaxes are included as git submodules, so dependabot can easily create PRs to bump them automatically

from syntect.

I think I see. It looks like if testdata/Packages/*/*.sublime-syntax is present, then it will become available as a SyntaxSet.

In which case, my next step is to try to get https://github.com/kurokirasama/nushell_sublime_syntax added to https://github.com/sublimehq/Packages

ah, but sublimehq/Packages isn't accepting new packages

from syntect.

would it be reasonable to add https://github.com/kurokirasama/nushell_sublime_syntax as an additional submodule, perhaps to: testdata/MoarPackages, and to update the build to load syntax from testdata/Packages + testdata/MoarPackages? .. or something roughly along those lines?

from syntect.

It may be reasonable, but I'm not yet convinced it's something we want in syntect as then we'll open the floodgates for requests for getting all sorts of packages added to syntect by default. (see #523 (comment) for example.) Please help me to understand for what reason do you want it in this repository as opposed to in your consumer codebase?

from syntect.