Comments (4)
Yep. Everyone should fork the repo and submit pull requests for Veqyrn and I to review for now.
from triplea.
I'll add one more important point which is please make small commits that are properly commented. Its much easier to review small commits that make it obvious what they are doing rather than huge commits that make lots of changes. It also allows us to accept changes at a finer grain rather than having to reject a large commit because of an issue with a small part of it.
This is especially important since there are only 2 of us reviewing pull requests right now and Veqryn has been pretty busy recently.
from triplea.
@ron-murhammer I want to avoid confusion and be clear on what this process would look like (I think there is some confusion since forks are not so pertinent):
- all the time there are pull requests going into triplea/master, and developers pull from it in order to integrate. Periodically a release branch is cut, tested in more detail, bug fixes are applied to it + master, and a release happens. That branch is "thrown away" and the process repeats.
Continuous integration means integrating often, my intent here is to designate master/triplea as the integration branch. This means dev's push there often and pull from there so that they integrate often.
from triplea.
Closing, at some point maybe later today I'll try to document this on the wiki. The integration+release process I think should be documented somewhere, probably there.
from triplea.
Related Issues (20)
- ConcurrentBattleCalculator#calculate:196 - java.lang.IllegalStateException HOT 1
- World at War Sub Issue HOT 2
- Battle calculator not pre-filling units on friendly countries... HOT 8
- Saved game loading HOT 3
- ImageFactory#lambda$getImageOrThrow$0:51 - java.lang.IllegalStateException HOT 1
- 2.5.22294: ClientFileSystemHelper - Error, could not create map download folder: /Users/niels91/Documents/triplea/downloadedMaps
- 2.5.22294: HeadedGameRunner
- Air Battles 2.6+ HOT 1
- World at War 2.1.1 - Fighters don't defend against Bombers??? HOT 3
- 2.5.22294: NodeBbForumPoster#uploadSaveGame:163 - java.lang.ClassCastException
- 2.5.22294: SimpleUnitPanel - missing unit icon (won't be displayed): stationJapanese, UnitImageFactory.ImageKey(player=PlayerId named...
- 2.5.22294: UnitsDrawer - MISSING UNIT IMAGE (won't be displayed): Mobilefactory, UnitImageFactory.ImageKey(player=PlayerId named:Poli...
- 2.5.22294: UnitsDrawer - MISSING UNIT IMAGE (won't be displayed): Mobilefactory, UnitImageFactory.ImageKey(player=PlayerId named:Poli...
- 2.5.22294: UnitsDrawer - MISSING UNIT IMAGE (won't be displayed): infantry_hit, UnitImageFactory.ImageKey(player=PlayerId named:Germa...
- 2.5.22294: TripleAFrame - Failed to set round icon for PlayerId named:Chinese
- History#gotoNode:123 - java.lang.IllegalStateException HOT 1
- 2.5.22294: DicePanel#setDiceRoll:49 - java.lang.NullPointerException
- 2.5.22294: UnitsDrawer - MISSING UNIT IMAGE (won't be displayed): factory1, UnitImageFactory.ImageKey(player=PlayerId named:China, ty...
- 2.5.22294: ProLogWindow#addMessage:381 - java.lang.OutOfMemoryError
- 2.5.22294: SimpleUnitPanel - missing unit icon (won't be displayed): armourGermans, UnitImageFactory.ImageKey(player=PlayerId named:G...
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from triplea.