ResourceCollection#removeResource:54 - java.lang.IllegalArgumentException about triplea HOT 8 CLOSED

This is not new to 2.6

from triplea.

Is there a repro?

from triplea.

@asvitkine I am unable to reproduce. I believe I have confused the issue with another.

Don't remember it exactly. It had something to do with negative PUs. Triplea had never been able todo it, so it wouldn't be a new 2.6 introduced issue.

I will continue to try and find a example

from triplea.

I think it was triplea can't give negative PUs. As in less than zero. Can have negative PUs but only against a positive PU total. I'll keep trying to find an example but think that's what it was or is :)

from triplea.

@asvitkine I was wrong. I can't produce what I thought was the issue in 2.5 or 2.6.

The Objective is minus 10 PUs and woks without throwing a error when a player has less than 10 PUs.

Apologies for any distraction this may have caused.

Edit
Using 2.6+14586

Edit 2
I just tried with 14647 and the behavior was the same

from triplea.

I noticed this is happening in the production panel code specifically.

ProductionPanel.calculateLimits

Let me look.

from triplea.

So I think this would happen if for some reason you had more units selected to purchase then what you can pay for.
I'm just not sure how that can happen.
I'll note that the new save game persisting code of purchases is around here, so maybe something wrong with that...

from triplea.

I think this is definitely related to the 2.6 code to keep units in saved games.
It happens in a network gamed for a joined player, the code ends up restoring the units from last turn, and if there's not enough PUs this error happens, preventing purchase phase.

@DanVanAtta FYI, we should probably block 2.6 release for this.

from triplea.