Giter Club home page Giter Club logo

Comments (5)

MarkPieszak avatar MarkPieszak commented on June 29, 2024 2

Yeah I think we might need to omit it entirely and warn people that they need to add that code themselves if they want it to handle those events, let me test a few things out.

from angular-application-insights.

MarkPieszak avatar MarkPieszak commented on June 29, 2024

Thanks for letting me know! Let me try and take a look.
I'm wondering if having that dependency be @Optional() will help fix the problem and we can just test to see if it's there in the service before making those calls.

from angular-application-insights.

GFoley83 avatar GFoley83 commented on June 29, 2024

I'm not sure but I don't think using @Optional will work here and you'd still be importing @angular/router, which is what will throw the error as it won't be installed.

from angular-application-insights.

fakerLinXiao avatar fakerLinXiao commented on June 29, 2024

@MarkPieszak Hello. I use ionic too. The error is "No module for @angular/router". How to resolve it?
"@angular/core": "4.1.2"
"@markpieszak/ng-application-insights": "^2.4.2"

from angular-application-insights.

MarkPieszak avatar MarkPieszak commented on June 29, 2024

Fixed with the latest version 5.0.4 @GFoley83
We're grabbing the Router via the Injector now, so it shouldn't have any issues now!
Sorry about the delay there.

Closing out but please open up if it still didn't fix it!

from angular-application-insights.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.