Comments (5)
- Option 2 doesn't allow the distinction between info and debug that we are currently using.
- Option 3 introduces another
if
in the system, and I prefer to avoid doing that (we should only use the logger, with as few exceptions as possible) - Option 4 seems the lesser evil, and would be my choice. We can still get database statistics using --runtime-statistics and --explain-query-plan.
from dispersy.
We could add a special verbose level for just the sql stuff.
http://stackoverflow.com/questions/9042919/python-logging-is-there-something-below-debug
from dispersy.
That would solve this problem. But is it the right thing to do here? It means that we will be using a 'modified' version of the standard logging. Keeping to the standard has its benefits in readability and cleanness.
As the author of the first post points out: "though the docs say that that should rarely be necessary and may even be undesirable".
from dispersy.
Don't trust the internets, the docs don't actually say that. They say: "Defining your own levels is possible, but should not be necessary, as the existing levels have been chosen on the basis of practical experience."
However, I do agree with you that is seems to be a bit of a hack. Alternatively we could simply use the NOTSET level.
logger.log(logging.NOTSET, 'msg')
from dispersy.
Yes, using NOTSET would be a good alternative.
from dispersy.
Related Issues (20)
- Test test_tracker in TestBootstrapServers is unstable HOT 1
- The upgrade procedure is not tested and goes back to version 1
- Generator only used to get one item? HOT 2
- TaskManager tests are hanging. HOT 2
- Refactor _resume_delayed HOT 1
- The libnacl submodule can be removed
- The add and add_keys in the bloomfilter contain identical code
- The test to check whether the bootstrap servers are up should be fixed
- Get rid of all the hard-coded sleeps in the tests
- meta_message table is filled with duplicates
- Linux unit tests pass on PR with error HOT 1
- Error when changing meta messages on community upgrade HOT 1
- The Dispersy tracker stress test could be part of our tests HOT 1
- Make Dispersy available on PyPi HOT 3
- Remove DoubleMemberAuthentication
- Bootstrap server test does not work anymore after n-hop sync HOT 3
- Infinite growing dictionary in Dispersy statistics HOT 2
- Add new release HOT 1
- Missing license HOT 2
- Speeding up torrent downloads in Tribler - Peer Video Club HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dispersy.