Comments (5)
One could argue that checking the max size of the packet is the responsibility of the user. Similar to checking that the packet is non empty string, which is currently also the responsibility of the user.
Also, you say that this will +/- crash the endpoint, what do you mean by this? Does it crash, or doesn't it?
from dispersy.
It will block the endpoint, the packet will not be send due to being too large and hence the endpoint will try again after X seconds.
from dispersy.
Btw, one could argue that this will help the user debug its community as it's really well hidden that this is causing the endpoint to fail.
from dispersy.
That is why the user should generally debug its community in debug mode where this check should definitely be included.
from dispersy.
Niels is right, a bug like this should not go unnoticed if a simple if
statement can clarify what is going on. Is #86 sufficient to make endpoint more user friendly?
from dispersy.
Related Issues (20)
- Test test_tracker in TestBootstrapServers is unstable HOT 1
- The upgrade procedure is not tested and goes back to version 1
- Generator only used to get one item? HOT 2
- TaskManager tests are hanging. HOT 2
- Refactor _resume_delayed HOT 1
- The libnacl submodule can be removed
- The add and add_keys in the bloomfilter contain identical code
- The test to check whether the bootstrap servers are up should be fixed
- Get rid of all the hard-coded sleeps in the tests
- meta_message table is filled with duplicates
- Linux unit tests pass on PR with error HOT 1
- Error when changing meta messages on community upgrade HOT 1
- The Dispersy tracker stress test could be part of our tests HOT 1
- Make Dispersy available on PyPi HOT 3
- Remove DoubleMemberAuthentication
- Bootstrap server test does not work anymore after n-hop sync HOT 3
- Infinite growing dictionary in Dispersy statistics HOT 2
- Add new release HOT 1
- Missing license HOT 2
- Speeding up torrent downloads in Tribler - Peer Video Club HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dispersy.