Giter Club home page Giter Club logo

Comments (5)

boudewijn-tribler avatar boudewijn-tribler commented on June 1, 2024

One could argue that checking the max size of the packet is the responsibility of the user. Similar to checking that the packet is non empty string, which is currently also the responsibility of the user.

Also, you say that this will +/- crash the endpoint, what do you mean by this? Does it crash, or doesn't it?

from dispersy.

NielsZeilemaker avatar NielsZeilemaker commented on June 1, 2024

It will block the endpoint, the packet will not be send due to being too large and hence the endpoint will try again after X seconds.

from dispersy.

NielsZeilemaker avatar NielsZeilemaker commented on June 1, 2024

Btw, one could argue that this will help the user debug its community as it's really well hidden that this is causing the endpoint to fail.

from dispersy.

boudewijn-tribler avatar boudewijn-tribler commented on June 1, 2024

That is why the user should generally debug its community in debug mode where this check should definitely be included.

from dispersy.

boudewijn-tribler avatar boudewijn-tribler commented on June 1, 2024

Niels is right, a bug like this should not go unnoticed if a simple if statement can clarify what is going on. Is #86 sufficient to make endpoint more user friendly?

from dispersy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.