Giter Club home page Giter Club logo

Comments (3)

boudewijn-tribler avatar boudewijn-tribler commented on June 12, 2024

The default Dispersy behavior is to ignore messages from communities that are not defined, having the autoload in LaunchManyCore overrides this behavior, allowing better propagation of killed messages.

I prefer not to have any autoloads defined by Dispersy. It can get slightly confusing as Dispersy itself doesn't define any communities, so why should it define any killed communities? Also, the autoload ordering currently determines the unload community ordering as well.

Ideally, communities should use their own HardKilledCommunity subclass and define (or choose not to) it for auto loading. So the best solution would be to replace the autoload with community specific autoloads.

from dispersy.

NielsZeilemaker avatar NielsZeilemaker commented on June 12, 2024

If it's Tribler specific, then its fine. I was just wondering why it was configured like this.

from dispersy.

boudewijn-tribler avatar boudewijn-tribler commented on June 12, 2024

Yea, I'm not liking the way we do the config now. Since the load=True was included the define_auto_load has become something else. Perhaps we should rename the method to reflect this change?

from dispersy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.