Both `if` branches have the same code about anydex-core HOT 3 CLOSED

Good find, go ahead 👍

from anydex-core.

Ah, wait, I think I totally misread the code.

if self.order.is_ask():
    if tup1[1] < tup2[1]:
        return 1
    else:
        return -1
else:
    if tup1[1] < tup2[1]:
        return -1
    else:
        return 1

When looked at in isolation the returned value is -1 if the order is an ask and 1 if not. Basically the results returned are flipped, depending on whether order is an ask or not. Uniting the two cases would break behavior.

My apologies for missing it and opening a frivolous issue. I totally missed the difference when reading it!

from anydex-core.

No problem! IIRC, the match queue was made quite close to the conference deadline, so I was a bit in a rush writing it. This did also not result in the most readable code 😁

from anydex-core.