Giter Club home page Giter Club logo

Comments (10)

trenpixster avatar trenpixster commented on June 29, 2024

@c-rack It's always nice to have dependencies up to date, but I'd postpone this until we really need those dependencies bumped; the reason for this is that there may be people using Addict with an older version of Phoenix/Ecto and this kind of requirement might be really cumbersome for them 😄

from addict.

bkochendorfer avatar bkochendorfer commented on June 29, 2024

👍 I'd like to use this library but it looks like I can't right now :).

from addict.

trenpixster avatar trenpixster commented on June 29, 2024

@bkochendorfer sorry about that, what Phoenix and ecto versions are you running?

from addict.

bkochendorfer avatar bkochendorfer commented on June 29, 2024
  defp deps do
    [{:phoenix, "~> 0.10.0"},
     {:phoenix_ecto, "~> 0.1"},
....

from addict.

bkochendorfer avatar bkochendorfer commented on June 29, 2024

FYI, I was able to get this to work by vendoring the library locally and updating the dependencies. The only major difference from the example_app in this repo is adding the csrf_token to each post request. You can get this pretty easily in your template using <%= get_csrf_token %>.

from addict.

sajmoon avatar sajmoon commented on June 29, 2024

Could the dependency be specified with > 0.8.0, thus allowing everybody to use it? I know it will fail due to csrf but that should be fixable.

from addict.

stevegraham avatar stevegraham commented on June 29, 2024

Why do the dependencies need to be strict? If everything is following semver, surely the only issue is making sure major doesn't increment?

from addict.

trenpixster avatar trenpixster commented on June 29, 2024

Yup, you're right guys. I'll update the semver accordingly. Thanks all for raising the issue!

from addict.

DanCouper avatar DanCouper commented on June 29, 2024

Really minor, but could you push to Hex with the relaxed deps? Currently pulling direct from here, so not really an issue, but would be nice to just define deps as normal

from addict.

trenpixster avatar trenpixster commented on June 29, 2024

Should be fixed on hex.pm v0.0.5 😄

from addict.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.