ignores ARTIFACTS_KEY from repository settings about artifacts HOT 13 CLOSED

@toolbear Sorry about the big delay. So far I've been unable to reproduce this bug, e.g.: https://travis-ci.org/meatballhat/cloaked-octo-tyrion/jobs/52970506. I'm waiting to hear back about the OSX build: https://travis-ci.org/meatballhat/cloaked-octo-tyrion/jobs/52970509, wondering if there's some critical difference in the build env such that the ARTIFACTS_* vars are being unset...

from artifacts.

No worries. I'm not blocked. I stopped pursuing travis-artifiacts and travis-deploy when I discovered that both are intentionally disabled on pull requests.

from artifacts.

I wonder if you may have more success trying to reproduce with language: objective-c instead of os: osx?

from artifacts.

@toolbear Gotcha. The behavior wrt pull requests is a great point. I'll ask around to see if this is something we should reconsider or at least make configurable. As for language: objective-c vs os: osx, I'll give it a shot 😺

from artifacts.

@toolbear the plot thickens: https://travis-ci.org/meatballhat/cloaked-octo-tyrion/builds/52994402 (:confused: :exclamation:)

from artifacts.

dramatic

Cursory look, the only difference I notice is that I didn't provide an explicit ARTIFACTS_BUCKET…

If you don't mind leaving it open a while longer, I can try again later this week or over the weekend.

from artifacts.

@toolbear friendly bump 😺

from artifacts.

I too seem to be experiencing this issue.

from artifacts.

I am also having this issue

from artifacts.

No worries. I'm not blocked. I stopped pursuing travis-artifiacts and travis-deploy when I discovered that both are intentionally disabled on pull requests.

Support for pull requests would be a useful feature for me as well.

from artifacts.

@toolbear @meatballhat I've opened a feature request issue at Travis CI to implement artifact uploads for pull requests. travis-ci/travis-ci#5579

from artifacts.

Is this still an issue for push builds? https://travis-ci.org/BanzaiMan/homebrew-cask/builds/131510102 shows $ARTIFACTS_KEY is respected.

The use of secure variables in a PR is a separate issue which is discussed elsewhere.

from artifacts.

afaict this bug has been addressed. Please yell if you find otherwise! ❤️

from artifacts.