Are there new operators to do things cheaply? Do we make things uncheck

<a target="_blank" rel="noopener noreferrer nofollow" href="https://user-images.github

We also do exponentiation here which I think can be unchecked: <a href="https://github

Pretty small savings <a target="_blank" rel="noopener noreferrer nofollow" href="h

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

🔍 Look at use of bitshifts and if they can be optimized post 0.8 about solmate HOT 6 CLOSED

transmissions11 commented on August 17, 2024

🔍 Look at use of bitshifts and if they can be optimized post 0.8

from solmate.

Comments (6)

rajivpo commented on August 17, 2024 1

from here: https://docs.soliditylang.org/en/v0.8.7/control-structures.html#unchecked

from solmate.

transmissions11 commented on August 17, 2024 1

We also do exponentiation here which I think can be unchecked: https://github.com/Rari-Capital/solmate/blob/370f014278419d6d11687decfa9d2b30d173d4c3/src/auth/authorities/RolesAuthority.sol#L89

from solmate.

rajivpo commented on August 17, 2024 1

I think this does apply but would wanna double check to be sure.

from solmate.

rajivpo commented on August 17, 2024 1

Pretty small savings

the tests in question are

function testUserHasRole() public {
        uint8 rootRole = 0;
        roles.setUserRole(self, rootRole, true);
        assertTrue(roles.doesUserHaveRole(self, rootRole));
    }
function testUserHasRoleUnchecked() public {
        uint8 rootRole = 0;
        roles.setUserRole(self, rootRole, true);
        assertTrue(roles.doesUserHaveRoleUnchecked(self, rootRole));
    }

where doesUserHaveRoleUnchecked is

function doesUserHaveRoleUnchecked(address who, uint8 role) external view returns (bool) {
        bytes32 roles = getUserRoles(who);
        unchecked {
            bytes32 shifted = bytes32(uint256(uint256(2)**uint256(role)));
            return bytes32(0) != roles & shifted;
        }
    }