Giter Club home page Giter Club logo

Comments (4)

kvz avatar kvz commented on August 15, 2024

/cc @MMasterson

As for the deprecation period, we won't pull that repo off the internet before TransloaditKit reaches stable and satisfies ~all customers. And even then it will probably be available for reference somewhere. But we'll be encouraging everyone to try TransloaditKit as it features tus.io, a responsive/approachable maintainer, and a number of other improvements over the ios-sdk. We'd surely be happy to learn what is still missing to make a good replacement besides this issue that you already reported tho, hat greatly helps us steer this in the right direction for our users.

from transloaditkit.

apersaud avatar apersaud commented on August 15, 2024

Thanks @kvz. I can definitely provide feedback once I can get things up and running with the new SDK. One thing that can be improved while we wait for code changes would be in the area of documentation (maybe including Swift examples), making sure Obj-C code is Swift 3 compatible (using macros so that objc function names are properly mapped to Swift).

The example code provided seems a bit hard to read as well. It seems we are invoking the assembly (similar to the previous SD) inside the completion block of the same object? (Taken from Example/TransloadIt/TransloaditViewController. Would be great if the example source code also had documentation.

transloadit.completionBlock = ^(NSDictionary* completionDictionary){
     [TestAssemblyWithSteps setUrlString:[completionDictionary valueForKey:@"assembly_ssl_url"]];
     [transloadit invokeAssembly:TestAssemblyWithSteps];       
};

Thanks

from transloaditkit.

MMasterson avatar MMasterson commented on August 15, 2024

The pod hasn't been fully published. However I am taking your requests to heart and will make sure we have full Examples for Swift 3, 4 and better documentation.

The non-modular header error will be fixed in the next release of the SDK (which will be provided on CocoaPods) set to be released this week.

*Edit:
@apersaud To mention on your point of invoking the assembly on the assebmlyCompletionBlock, that does not need to happen, it's done for the sake of a small and simple UI. You do however need to add the assebmly_ssl_url to the assembly object for when you do invoke.

from transloaditkit.

MMasterson avatar MMasterson commented on August 15, 2024

For now, and due to CommonCrypto being a non-modular header, we use a modular version written in Swift - Arcane- just import the dependency along with TransloaditKit as it shows in the README

from transloaditkit.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.