tests/translate/convert/test_rc2po.py failures with Python 3.12 about translate HOT 7 CLOSED

This will be most likely an issue with pyparsing, but I can't find anything related in their issue tracker, so we will need to figure out what is actually broken.

from translate.

Created pyparsing/pyparsing#517 to ask about pyparsing status.

from translate.

Confirmed in our CI environment: https://github.com/translate/translate/actions/runs/6771797656/job/18402990631

Can you try to isolate a smaller testcase as requested in pyparsing/pyparsing#517?

from translate.

I suppose I could try but can't promise anything. Already spent most of the day reducing slixmpp but hopefully this one's less convoluted ;-).

from translate.

Ok, I think it's actually output buffering problem in translate-toolkit. While debugging it, I've tried:

diff --git a/translate/convert/rc2po.py b/translate/convert/rc2po.py
index e4f02a6c..5bf9fa3f 100755
--- a/translate/convert/rc2po.py
+++ b/translate/convert/rc2po.py
@@ -122,6 +122,7 @@ def convertrc(
     if output_store.isempty():
         return 0
     output_store.serialize(output_file)
+    output_file.flush()
     return 1
 
 

and that makes all the tests pass. Though I suppose there is probably a better place to do the flushing.

from translate.

Thanks for good pointer, it is caused by not closing output file in the converters, #5073 should fix this.

from translate.

Thanks a lot! I can confirm that the commit fixes the issue.

from translate.