Comments (5)
Thanks Minh for your suggestion. It's definitely a great idea, I'll do that before releasing the next version and let you know when it's ready.
Best regards,
Hien
from lsd2.
Hi Minh,
In the latest commit 2ca847f, besides adding some features, I've changed FILE to iostream,istream and remove global variables. Could you check if it works now and let me know if anything else needs to be adjusted.
Thank you
Hien
from lsd2.
Awesome! I'll check that and also try to adapt the calling from files to streams, so that it fits into iqtree.
from lsd2.
After some testing I think LSD2 now runs really well -> great job!
Another item to add here:
- Make LSD2 compilable and run on Windows (in addition to Linux and Mac).
This is done and my test executable runs well on Windows 7.
For point 2 about thread-safety: I couldn't check yet. My only point right now is to avoid using those "old" C functions that are not thread-safe.
For example, the random number generator (srand
) are not safe. But I think you have now changed that to the C++ standard library, right?
from lsd2.
Thanks Minh for your work. It's also really nice that it runs on Windows now. I don't have experience in thread-safety so couldn't help much. But I no longer use srand. I'll try to see if there's anything else should be adjusted.
Hien
from lsd2.
Related Issues (20)
- Compiling error in Windows HOT 1
- Accepting dates in ISO format HOT 3
- Negative branch lengths despite -c option HOT 1
- Better error message for all unknown dates HOT 1
- Segmentation fault with -g option HOT 3
- Allow YYYY-MM-DD for tip and root dates HOT 2
- Request for date range specification
- Request to change mrca notation HOT 1
- More flexible date format HOT 7
- Understanding date notation in date file HOT 2
- Error with setting root date HOT 4
- Confidence interval values HOT 5
- unrooted bifurcating tree dating could output multifurcating trees HOT 1
- Date file with the format yyyy-mm-dd HOT 3
- is this okay for me HOT 1
- Relaxed Clock Parameters
- Details about confidence intervals HOT 2
- Issue with CI calculation on a datafile with constraints on internal nodes (v2.3) HOT 3
- Option -n broken HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lsd2.