Add functionality to include LSD2 as a library about lsd2 HOT 5 CLOSED

Thanks Minh for your suggestion. It's definitely a great idea, I'll do that before releasing the next version and let you know when it's ready.

Best regards,
Hien

from lsd2.

Hi Minh,

In the latest commit 2ca847f, besides adding some features, I've changed FILE to iostream,istream and remove global variables. Could you check if it works now and let me know if anything else needs to be adjusted.

Thank you
Hien

from lsd2.

Awesome! I'll check that and also try to adapt the calling from files to streams, so that it fits into iqtree.

from lsd2.

After some testing I think LSD2 now runs really well -> great job!

Another item to add here:

3. Make LSD2 compilable and run on Windows (in addition to Linux and Mac).

This is done and my test executable runs well on Windows 7.

For point 2 about thread-safety: I couldn't check yet. My only point right now is to avoid using those "old" C functions that are not thread-safe.

For example, the random number generator (srand) are not safe. But I think you have now changed that to the C++ standard library, right?

from lsd2.

Thanks Minh for your work. It's also really nice that it runs on Windows now. I don't have experience in thread-safety so couldn't help much. But I no longer use srand. I'll try to see if there's anything else should be adjusted.

Hien

from lsd2.