Giter Club home page Giter Club logo

Comments (9)

joeblau avatar joeblau commented on May 12, 2024

Where would you like to see that identified?

from gitignore.io.

bbodenmiller avatar bbodenmiller commented on May 12, 2024

Just somewhere in the README and on the docs section of the website. Perhaps in a section about how to contribute to the .gitignore templates.

from gitignore.io.

joeblau avatar joeblau commented on May 12, 2024

That has been in CONTRIBUTING.md since September of 2014 which is the same time I added GitHub's ignore as a submodule. This is also inline with GitHub's Contributing Guidelines. That being said, maybe I should add it somewhere else because a lot of people don't immediately seem to realize that there is a submodule.

from gitignore.io.

bbodenmiller avatar bbodenmiller commented on May 12, 2024

Glad to see it in CONTRIBUTING.md. My main thing was that I skimmed the README and couldn't find the source of the gitignore's nor where they were located in the repo. Additionally CONTRIBUTING.md says to PR to files to /data/gitignore/Custom. I think the community would be better off it they submitted them to https://github.com/github/gitignore and as a backup submitted them to your repo if gitignore does not want to accept.

from gitignore.io.

joeblau avatar joeblau commented on May 12, 2024

I think the community would be better off it they submitted them to https://github.com/github/gitignore and as a backup submitted them to your repo if gitignore does not want to accept.

That is how it works.

from gitignore.io.

bbodenmiller avatar bbodenmiller commented on May 12, 2024

I think a bullet under Adding/Updating Templates in CONTRIBUTING would make that a bit more clear.

from gitignore.io.

joeblau avatar joeblau commented on May 12, 2024

👍 go ahead and add what you think. I'll merge it.

from gitignore.io.

joeblau avatar joeblau commented on May 12, 2024

@bbodenmiller I'm actually going to close this because I just went back though some history and remembered why I created his project. The whole reason this project was created was because GitHub wasn't actually merging any PRs for months. I actually went though manually, commented on and merged a lot of PR's into my library at the time. So while GitHub has a good source, I'm still not going to recommend that people contribute there first as the original vision of this project is to become the authoritative source (which is also stated in the CONTRIBUTING.md).

from gitignore.io.

joeblau avatar joeblau commented on May 12, 2024

@bbodenmiller this is a perfect example of why I made this site: 59cc5a5

from gitignore.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.