[$1800] GStreamer pipeline unification about pxcore HOT 18 CLOSED

Contest https://www.topcoder.com/challenges/30103959 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

from pxcore.

Contest https://www.topcoder.com/challenges/30103959 has been updated - it has been assigned to kruntuid.

This is an automated message for ghostar via Topcoder X

from pxcore.

if I understand correctly
aamp gstreamer playback code from
https://github.com/topcoderinc/pxCore/tree/AAMP_Integration/examples/pxScene2d/external/aamp/aamp/*gst*
must be unified with webkit gstreamer internal playback pipeline.

webkit playback pipeline is split into several classes MediaPlayer*.
So I think there will a lot of work to extract/refactor/unify.

from pxcore.

@krunt - Yeah, that's my understanding. I can bump the payment up accordingly.

from pxcore.

@krunt - Any feedback on this one?

from pxcore.

I am thinking about design.
Maybe it's more correct to wait for webkit code integration to pxCore
and then try to unify pipeline?

If not - we can create common interface in externals/ (simular to StreamSink in aamp)
and patch webkit to use this interface internally.

What control do we need from pipeline? Much of gstreamer callbacks (busMessageCallback, need-data, bus_sync_handler, etc) have webkit/aamp specific implementations and should be hidden inside webkit/aamp. So what we got left is some pointers to gstreamer pipeline/bus, and maybe minimal logic to create pipeline, configure appsrc/appsink. Is this what is required by this task?

from pxcore.

A couple of things here:

1. We won't be doing the Webkit integration in the final solution. The final solution will be the "webkit-less" work we're doing to remove the Webkit dependency, so we have to keep that in mind.

2. Yeah, we can start with that and get client feedback.

from pxcore.

1. I meant by Webkit integration - webkit-less, so we have control over all webkit imported code
   and we are free to modify it inside pxcore.

This webkit-less solution is not ideal too - because we are not able to keep up with changes from webkit upstream.

from pxcore.

Yeah, but this is what the client wants currently. I don't think they expect the MSE implementation to change too much.

from pxcore.

@krunt - Any update on this? Anything else I can provide?

from pxcore.

I've committed initial version of unified pipeline
it is in examples/pxScene2d/external/gst-pipeline
we can later extend interface as needed
also patched webkit and aamp to use this pipeline.

I have some issues which I've not resolved with linking aamp on ubuntu 18.04
I imported external/aamp from AAMP_Integration branch
when linking spark I got
../../../../examples/pxScene2d/src/../external/aamp/aamp/build/libaamp.so: undefined reference to curl_easy_cleanup@CURL_OPENSSL_3' //usr/local/lib/libdash.so: undefined reference to curl_global_cleanup@CURL_OPENSSL_3'
//usr/local/lib/libdash.so: undefined reference to `curl_global_init@CURL_OPENSSL_3'
though curl3 and openssl 1.0 are linked in. I tried to build aamp with libcurl4 and openssl 1.1 but compilation fails in drm/*.
need investigate further

from pxcore.

is newer version of aamp available or the version on AAMP_Integration branch is ok?

from pxcore.

Ok, thanks for the update

from pxcore.

@krunt - Just checked in the latest from the client:

https://github.com/topcoderinc/pxCore/tree/_video

from pxcore.

I've imported aamp/aampabr/libdash from there, built successfully
committed to my fork

from pxcore.

@krunt - Great, thanks for the update. Is there anything else pending, or can I test this now?

from pxcore.

no pending, you can test aamp by running sample aampVideo.js, webkit by mse_video_player.js or dashjs_demo.js
common pipeline is in external/gst-pipeline/
it is minimal for now

from pxcore.

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30103959

This is an automated message for ghostar via Topcoder X

from pxcore.