ReactDOM.unstable_batchedUpdates breaks ReactNative about rum HOT 3 CLOSED

Hi @fonghou ! It’s so great you were able to test pre-release version of Rum. It’s also awesome you’re using it for ReactNative. In fact, I’d love to hear more about your experience with it. I’d like to support RN one day in Rum. Do you need to change a lot? Is it working as-is?

Regarding your problem, would something like that work?

(def ^:private batch
  (if (exists? js/ReactNative)
    js/ReactNative.unstable_batchedUpdates
    js/ReactDOM.unstable_batchedUpdates))
...
(defn- render []
  (let [queue @render-queue]
    (vreset! render-queue empty-queue)
    (batch render-all queue)))

from rum.

Hi @tonsky, I just checked out master. It works great! Thanks!

Rum actually works out of box as-is thanks to the awesome work from re-natal folks. For me, it's definitely the best workflow and environment for learning and/or prototyping mobile app.

Only thing that has to be excluded is sablono because of ReactDOM like this.

[rum "0.9.1" :exclusions [cljsjs/react cljsjs/react-dom sablono]]]

And define react comp factory functions as below.

(defn create-element [rn-comp opts & children]
  (apply js/React.createElement rn-comp (clj->js opts) children))

(def ReactNative (js/require "react-native"))
(def app-registry (.-AppRegistry ReactNative))
(def view (partial create-element (.-View ReactNative)))
(def text (partial create-element (.-Text ReactNative)))
(def text-input (partial create-element (.-TextInput ReactNative)))
(def list-view (partial create-element (.-ListView ReactNative)))
... 

In case you'd like to add some macro helper for above boilerplate (btw, I don't miss sablono that much as it's very DOM centric. Maybe a sepearte shorthand syntax for flexbox css?)

Regards

from rum.

I’ll try to figure out the best way to use Rum in both DOM and RN
environments, taking into account your advice. I’m very eager to try it out
for mobile development—the only problem being finding a free time for that
:(

On Fri, Jul 1, 2016 at 12:07 AM Fong Hou [email protected] wrote:

Hi @tonsky https://github.com/tonsky, I just checked out master. It
works great! Thanks!

Rum actually works out of box as-is thanks to the awesome work from
re-natal folks. For me, it's definitely the best workflow and
environment for learning and/or prototyping mobile app.

Only thing that has to be excluded is sablono because of ReactDOM like
this.

[rum "0.9.1" :exclusions [cljsjs/react cljsjs/react-dom sablono]]]

And define react comp factory functions as below.

(defn create-element [rn-comp opts & children](apply js/React.createElement rn-comp %28clj->js opts%29 children))

(def ReactNative (js/require "react-native"))
(def app-registry (.-AppRegistry ReactNative))
(def view (partial create-element (.-View ReactNative)))
(def text (partial create-element (.-Text ReactNative)))
(def text-input (partial create-element (.-TextInput ReactNative)))
(def list-view (partial create-element (.-ListView ReactNative)))
...

In case you'd like to add some macro helper for above boilerplate (btw, I
don't miss sablono that much as it's very DOM centric. Maybe a sepearte
shorthand syntax for flexbox css?)

Regards

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#77 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AARabOKOgFhe5nmB7-B2KQJVc0s5FHeLks5qRAXMgaJpZM4JBdN4
.

from rum.