Giter Club home page Giter Club logo

Comments (3)

tonsky avatar tonsky commented on July 19, 2024

Do you think this is important enough to fix? Why?

from rum.

gsnewmark avatar gsnewmark commented on July 19, 2024

It's not that important, because there are ways to avoid creation of few-level same component hierarchies, e. g. using multi-arity functions which call the single-arity component. Moreover, after additional thinking about it I feel that complexity introduced by possible 'fix' outweighs some minor inconveniences of multi-arity components I described in the issue.

For me the biggest problem was that initially I didn't really understand nature of multi-arity Rum components (each render fn of such components produces independent instance of React component) and because of this used them incorrectly (I was adding global event handler in multi-arity component's did-mount and this handler was fired a couple of times on each event - it took some time to find the real reason of such behavior).

from rum.

tonsky avatar tonsky commented on July 19, 2024

I gave it a look, it can be solved by giving anonymous render fn a name, but when used, it looked really bad and confusing. Better use a standalone multi-arity render function that is called from component.

from rum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.