React keys warning when component body within let about rum HOT 10 CLOSED

I'm having a similar problem.

from rum.

So, i've spent a couple of hours fighting this issue and lost. But i've found how render method will look like.

For example, for this component

(defc my-component < static [props]
  (let [x (:x props)]
    [:div {:class-name "test"}
      [:span "Test"]
      [:span (str "Test" x)]]))

render method will look like

;; Some brainfuck action here

(fn []
  (this-as this
           (let [state (state this)
                 [dom next-state] ((fn [state]
                                     [(apply (fn [props]
                                               (do (let [x (:x props)]
                                                     (js/React.createElement "div" {:className "test"}
                                                                             (js/React.createElement "span" nil "Test")
                                                                             (js/React.createElement "span" nil (str "Test" n))))))
                                        (::args state))
                                      state]) @state)]
             (vreset! state next-state)
             dom)))

So, I can't even imagine why this is happening.

from rum.

So key warning happens because sablono puts it into an array if component body does not start with vector. I’ll see if I can report it to them or work around it by myself

from rum.

It's reported at r0man/sablono#57

from rum.

Is there any fix to this? I'm getting this with sablono 0.5.3 and rum 0.6.0
Everything is fine if I wrap contents of let-block with (sablono.core/html ...) but it looks like a workaround...

from rum.

@tonsky This should be fixed in sablono 0.6.0.

from rum.

Awesome! Will check tomorrow

On Sun, Feb 14, 2016 at 8:41 PM r0man [email protected] wrote:

@tonsky https://github.com/tonsky This should be fixed in sablono 0.6.0.

—
Reply to this email directly or view it on GitHub
#33 (comment).

from rum.

Status update on this? Can we update sablono to 0.6.0?

from rum.

You can do it locally via :exclusions, it won’t break anything. Next
version of rum will also contain updated dependency

On Wed, Mar 2, 2016 at 2:00 AM Kenny Williams [email protected]
wrote:

Status update on this? Can we update sablono to 0.6.0?

—
Reply to this email directly or view it on GitHub
#33 (comment).

from rum.

[sablono 0.6.3] was included in [rum 0.7.0], which should have this issue fixed

from rum.