Giter Club home page Giter Club logo

Comments (5)

suntong avatar suntong commented on June 27, 2024

My plan is to mark all failed test to be skipped at Debian-build time with a call to the Skip method --

    if testing.Short() {
        t.Skip("skipping test that would fail in Debian-build.")
    }

However, the down side is that, it also means the test in short mode has an ambiguous meaning.

Due to my limited knowledge, this is the only way I know that can make it working.

from fsutil.

suntong avatar suntong commented on June 27, 2024

the down side is that, it also means the test in short mode has an ambiguous meaning

This will remove the ambiguity:

if testing.Short() && os.Getenv("DEB_BUILD_ARCH_OS") != ""  {
    t.Skip("skipping test that would fail in Debian-build.")
}

So now the changes will not have side effects.

Would you accept my PRs in this case?

from fsutil.

tonistiigi avatar tonistiigi commented on June 27, 2024

we can just skip things that require root. We already have smth like this

func requiresRoot(t *testing.T) {

from fsutil.

suntong avatar suntong commented on June 27, 2024

Thanks @tonistiigi, I'll skip the rest that require root and failed in Debian packaging, and submit a PR...

from fsutil.

suntong avatar suntong commented on June 27, 2024

Done. Please approve #78 and tag a new release.

from fsutil.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.