Comments (5)
My plan is to mark all failed test to be skipped at Debian-build time with a call to the Skip
method --
if testing.Short() {
t.Skip("skipping test that would fail in Debian-build.")
}
However, the down side is that, it also means the test in short mode has an ambiguous meaning.
Due to my limited knowledge, this is the only way I know that can make it working.
from fsutil.
the down side is that, it also means the test in short mode has an ambiguous meaning
This will remove the ambiguity:
if testing.Short() && os.Getenv("DEB_BUILD_ARCH_OS") != "" {
t.Skip("skipping test that would fail in Debian-build.")
}
So now the changes will not have side effects.
Would you accept my PRs in this case?
from fsutil.
we can just skip things that require root. We already have smth like this
Line 21 in 013a9fe
from fsutil.
Thanks @tonistiigi, I'll skip the rest that require root and failed in Debian packaging, and submit a PR...
from fsutil.
Done. Please approve #78 and tag a new release.
from fsutil.
Related Issues (18)
- missing pkg: github.com/tonistiigi/fsutil/util HOT 3
- validator catches false positives in windows for subdirs
- TestCopySimple fails HOT 4
- Add TestCopyExistingDirDest
- Question: is it intended to be a standalone library, or is it part of Docker? HOT 4
- flaky test: TestInvalidExcludePatterns
- Suggestion: move to moby/buildkit repo HOT 1
- undefined: proto.GoGoProtoPackageIsVersion3 HOT 2
- copyFileContent broken on zfs (in some cases) HOT 1
- freebsd ci broken
- TestCopySimple fails at head HOT 1
- `go get -u github.com/tonistiigi/fsutil` fails HOT 5
- Random Panic HOT 1
- optimize memory allocation in receiver
- Add Windows CI workflow
- clarify why copy.Copy is unsafe HOT 1
- tests: add test cases to cover Windows/Unix path conversions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fsutil.