Giter Club home page Giter Club logo

Comments (4)

jsphweid avatar jsphweid commented on September 10, 2024

@appsforartists, I'm adding at least some of these now. I just realized how much is missing from that typings file, lol. I'm almost tempted to convert the entire project to a typescript project so it can autogen and be up-to-date always.... Hmm....

from midi.

appsforartists avatar appsforartists commented on September 10, 2024

My general philosophy is that typings should match the documentation; since the README doesn't include the chains, the typings didn't either.

In general, I would float proposals by @tambien before PRing them. We of course appreciate help, but changing tabs to spaces or converting the project to a different toolchain are big steps to take without confirming they are desired.

from midi.

jsphweid avatar jsphweid commented on September 10, 2024

Well, my general philosophy is that typings should match the code: i.e. when your code tries to compile but can't because of a faulty .d.ts file (https://gyazo.com/e0a9aa8cf11f3c97c7e95f7f6a413778), no amount of having a slightly different "philosophy" is going to help you... lol. In addition, the pic is an example literally taken from the documentation anyways, lol (https://gyazo.com/8e1fb29cf0df442da24774b64f51be1f).

I can't convince myself that this is intentional. It was either written incorrectly or out-of-date / incomplete. Given the existence of this thread, it seems to be the latter.

Forget the typescript thing. It wasn't that serious.

Not sure what you mean about changing tabs to spaces.

from midi.

tambien avatar tambien commented on September 10, 2024

updated api and d.ts file. i don't think this issue is relevant any longer. closing, but feel free to open it if there is still an issue.

from midi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.