[question] Convert PcSet to Scale about tonal HOT 4 CLOSED

Hi!,

The solution is harder than I thought:

const Tonal = require('tonal');

const notes = ['a', 'b', 'e', 'g'];
const intervals = PcSet.intervals(PcSet.chroma(notes)));
const scale = intervals.map(Tonal.transpose('A4'))

One problem is that PcSet.intervals doesn't accept the note array directly (but the documentation says it can). I'll keep the issue open while deciding what to do.

I hope it helps.
Suggestions and PR welcomed.

from tonal.

Hey @danigb!

Thank you for the quick response.

Pasting the following code

var tonal = require("tonal")

const notes = ['a', 'b', 'e', 'g'];
const intervals = tonal.PcSet.intervals(tonal.PcSet.chroma(notes));
const scale = intervals.map(tonal.transpose(`${notes[0]}4`)); // same with 'A4'

to RunKit gives me this result:

Array (4 items)
0: "C#5"
1: "E5"
2: "F#5"
3: "G#5"

from tonal.

True! It works with ["a", "c", "e", "g"] but not with ['a', 'b', 'e', 'g']. I'll investigate the issue...

from tonal.

This works and it's a better alternative:

var tonal = require("tonal")

const notes = ['a', 'b', 'e', 'g'];
const intervals = notes.map(tonal.interval(notes[0]))
intervals.map(tonal.transpose(`${notes[0]}4`))

EDIT: in fact the function (notes) => notes.map(tonal.interval(notes[0]))) used to be in tonal (was called Distance.harmonics). Maybe it's time to reintrorduce it?.

Ideas?

from tonal.