Giter Club home page Giter Club logo

Comments (3)

danigb avatar danigb commented on July 16, 2024 1

I think it's solved and I've published a new version. Thanks to your research, solve the issue was trivial. Thanks! 👍

from tonal.

danigb avatar danigb commented on July 16, 2024

Hi @mahavira, thanks for reporting. I'll take a look at this issue soon.

from tonal.

rowild avatar rowild commented on July 16, 2024

@mahavira It seems "chord('alt7')", "chord('dim')" and "chord('dim7')" do not generate a proper object (chroma, pcset, intervals... missing)

I currently use workarounds like these:

// Workaround for "dim" and "dim7"
if(selectedChord === 'dim' || selectedChord === 'dim7') {
  selectedChord = '°7'
}

// Workaround for "alt7"; could affect more then just "alt7", since there could be
// more entries with "empty: true"
let chordIntervals = null;
if(chord(selectedChord).empty !== true) {
  chordIntervals = chord(selectedChord).intervals
} else {
  chordIntervals = chordType(selectedChord).intervals
}

from tonal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.