whitelist is not working about gocd-yaml-config-plugin HOT 11 CLOSED

You can see how to use whitelist under here. You either specify whitelist or blacklist.

What do you mean by ?

invert_filter is not set to true when using whitelist

How did you configure pipeline material? What do you expect from whitelist.

from gocd-yaml-config-plugin.

gocd version: 17.12.0
material type: hg

image_nexus:
    group: images
    materials:
      xxx:
        hg: ssh://[email protected]/xxx
        whitelist:
          - images/nexus/**/*

curl to get pipeline settings

  "materials": [
    {
      "type": "hg",
      "attributes": {
        "url": "ssh://[email protected]/xxx",
        "destination": null,
        "filter": {
          "ignore": [
            "images/nexus/**/*"
          ]
        },
        "invert_filter": false,
        "name": "xxx",
        "auto_update": true
      }
    }
  ],

now lets try blacklist

  image_nexus:
    group: images
    materials:
      xxx:
        hg: ssh://[email protected]/xxx
        blacklist:
          - images/nexus/**/*

curl

  "materials": [
    {
      "type": "hg",
      "attributes": {
        "url": "ssh://[email protected]/xxx",
        "destination": null,
        "filter": {
          "ignore": [
            "images/nexus/**/*"
          ]
        },
        "invert_filter": false,
        "name": "xxx",
        "auto_update": true
      }
    }
  ],

on whitelist, invert_filter should be true, I have tried the same setup manually using UI and it works as expected, I have a bunch of docker images and they all rebuild even if I change only one, whitelist should prevent this

from gocd-yaml-config-plugin.

Hey, were you able to confirm this?

from gocd-yaml-config-plugin.

I started looking at this, but then ran into problems into getting intellij working on gocd gradle project due to some silly errors.
I need to debug both server and plugin to get why this is not working. I am sure whitelist works fine on git, because it's part of tests. No clue why it would not work on hg. But that API response is certainly unexpected.

from gocd-yaml-config-plugin.

Thanks

from gocd-yaml-config-plugin.

@tomzo You know this code best, but this line seems to be missed here. As you can see in the next line, invertFilter is always set to false.

from gocd-yaml-config-plugin.

@arvindsv thanks, that was it.
The fix was easy, but I've spent about 2 hours trying to figure out why I cannot import project to intellij. Apparently older version 2017.1 does not work with gradle 4.x, at least for GoCD.
The PR is testing gocd/gocd#4191 , I'll merge once it passes.

from gocd-yaml-config-plugin.

Any chance of a release to address this? 0.6.1 ?

from gocd-yaml-config-plugin.

@shomodj the bug is fixed in the core. You'll need to upgrade server to version 18.1

from gocd-yaml-config-plugin.

Cool, thanks

from gocd-yaml-config-plugin.

Fixed in server 18.1+

from gocd-yaml-config-plugin.