Giter Club home page Giter Club logo

Comments (2)

khuang247 avatar khuang247 commented on August 28, 2024

So I've added in a circular loader with just CSS to keep it simple.

One issue I've been coming across is that the loading bar disappears before the content fully loads (on first load). I believe this is because the function ends first, then the HTML elements for the MAC addresses load after. For subsequent loads, the content loads right away and the loading circle disappears seconds after. This isn't a big issue, but I can fix this after we've merged everything and I'll go back an restructure the way modal loads.

On another note, I've chucked the loader CSS into modal, which I feel should be its own CSS file for cleanliness sakes.

Design choices, its currently a light blue quarter of a circle spinning on a grey background. Thoughts?

@RyanH1234

from spa.

RyanH1234 avatar RyanH1234 commented on August 28, 2024

Sounds good - we can go over refactoring on Wednesday, design choice sounds good

from spa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.