Giter Club home page Giter Club logo

Comments (5)

arp242 avatar arp242 commented on August 19, 2024 1

Fixed in 55be821

from toml-test.

arp242 avatar arp242 commented on August 19, 2024

Your PR #138 fixed this (there's already a exp-leading-us test, so no need to do anything else).

from toml-test.

gnarlyquack avatar gnarlyquack commented on August 19, 2024

PR #138 changed exp-trailing-us.toml, which tests:

exp-trailing-us = 1e23_

trailing-us-exp.toml tests:

trailing-us-exp = 1_e2
trailing-us-exp2 = 1.2_e2

Each test has an invalid underscore in different positions of the float. Assuming we want to test against all these scenarios, it seems to me that the tests in trailing-us-exp.toml should be split out.

Normally I'd just submit a PR, but I think that adding/removing tests may require some changes in the binary in addition to just changing the tests, and I don't know the first thing about Go.

from toml-test.

arp242 avatar arp242 commented on August 19, 2024

adding/removing tests may require some changes in the binary in addition to just changing the tests, and I don't know the first thing about Go.

The entire directory is included; you don't need to do anything to add or remove a test other than create a file.

from toml-test.

gnarlyquack avatar gnarlyquack commented on August 19, 2024

Thank you for the fix!

The entire directory is included; you don't need to do anything to add or remove a test other than create a file.

I'll keep that in mind if I have future PRs.

Do the tests\files-toml-x files need to be updated?
Ah, it looks like it's all auto-generated. Thanks again!

from toml-test.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.