Giter Club home page Giter Club logo

Comments (3)

tomfulton avatar tomfulton commented on July 22, 2024

Hi, thanks for reporting!

For the issue with the <files /> element, the usage is a bit strange, you need to hardcode the list of files currently. In Archetype we do this using grunt templates and some logic in the package.xml file to generate the list automatically. I believe it was done this way due to lack of xml parsing node packages at the time (that didn't require python).

Anyway, I'd gladly accept your pull request to generate the manifest automatically, that sounds much more ideal. Do you think there is any value in keeping the current behavior and making the "automatic" manifest optional, or should we just get rid of it altogether and define everything in the config?

I also agree with your other comments, both should be easy fixes...if you have time for a pull request I'll gladly take a look 😄

from grunt-umbraco-package.

abjerner avatar abjerner commented on July 22, 2024

I suppose specifying the path to the manifest can be made optional. If specified, it will just copy the manifest. If not specified, the manifest will automatically be generated by the package.

I'll look into implementing that, and then make a pull request ;)

from grunt-umbraco-package.

abjerner avatar abjerner commented on July 22, 2024

Closing the issue here since I've now created a pull request: #8.

from grunt-umbraco-package.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.