Used and Useless variable about pa193_mnemonic_bugsbunny HOT 2 OPEN

This was intended because I as the programmer do not like changing arguments within a function. I also wanted it to be clear that the dictionary used during computation does not necessarily have to be the same that we got in an argument (it can default to our EN). There is also a point to having this argument as const, because it shows the programmer, that the provided dictionary is not changed and this function indeed treats it like const. I am aware that this variable is omitted during compilation and I deliberately chose to include it nevertheless for the sake of the code.

I will mark this as not a bug, but thank you for the question. I would also like to hear your arguments for removing it because my point of view can be absolutely stupid and it may be irrelevant to most other developers :)

from pa193_mnemonic_bugsbunny.

Indeed, it is only one pointer more in the stack, it is not really important.

In addition, I agree that the it can add more legibility in the code. It is something really interesting because user could think that, if they give a pointer in parameter, and if the pointer is on NULL, then they would get the default dictionary at the end of the function execution.

For instance :

struct dictionary *dictionary = NULL;
int err = entropy_to_mnemonic(my_dico, entropy, entropy_l, &output);

The function, even if my_dico is NULL before, will not change the value of my_dico.
So, creating a local variable, to show that the dictionary used in the function has not any impact on the arguments, can be useful for beginner.

from pa193_mnemonic_bugsbunny.