Comments (6)
Thank you for reporting! I am almost certain this is related to the new header parsing code we introduced. The line you are referring to does this:
responses = Patron::HeaderParser.parse(header_data_for_multiple_responses)
last_response = responses[-1] # Only use the last response (for proxies and redirects)
It is a bit hard for me to imagine how the responses
can be nil in this case, and I doubt I can reproduce this myself without your help. Can you set up a smaller app that demonstrates the problem? If you don't feel like sharing your cassette that causes it on GH you can pass it directly to me off-band and I will see to it that we rectify it into a test case.
from patron.
@henrik ?
from patron.
Hi @julik! Sorry about the delay in replying. Thank you, that makes sense. I emailed you a cassette in case that helps – I'm rather limited for time right now, but I've made a note of this ticket in our codebase and will write again if we come back to this code and make a repro or a PR.
from patron.
Thanks, I'll play with it and get back to you.
from patron.
Thanks! I nailed the issue to Webmock doing things to the headers string it should not be doing.
from patron.
Oh, brilliant! Good job on figuring it out.
from patron.
Related Issues (20)
- Release 0.8 HOT 1
- Automate the Patron release process HOT 5
- Idea: Connection pooling using curl_multi HOT 4
- Add streaming upload/download support HOT 1
- Release new version HOT 2
- The Hive copyright comment HOT 1
- Respond to signals when outside the GIL HOT 3
- Headers aren't parsed correctly for first request when connection is proxied HOT 1
- Redirect handling inconsistency HOT 3
- RFC: Streaming response bodies HOT 8
- PATCH method doesn't send body HOT 4
- Gem not installed to ruby 2.1.2 HOT 1
- how to set ssl client_key / client_cert ? HOT 6
- Request: Render full server response as a string HOT 1
- Figure out the actual set of supported HTTP verbs
- --http1.1 option please HOT 1
- "checking for ruby/thread.h... *** extconf.rb failed ***" when installing on google/cloud-sdk:alpine docker image HOT 1
- one rspec test fails on Arch Linux
- Basic Auth HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from patron.