Giter Club home page Giter Club logo

Comments (14)

vrajat avatar vrajat commented on July 19, 2024

Now I remember why I had has_pii instead of pii column for databases. Piicatcher uses a library called tableprint to print the ascii table and it has its limitations. You've hit both of them.

  1. It is hard to format long columns
  2. It expects a terminal to print a table. It cant be redirected to a file.

I am not sure there is an easy fix for either of them. I suggest you use JSON to store to a file. In #51 I'll improve JSON format to also include the PII types.

from piicatcher.

jayeshagwan1 avatar jayeshagwan1 commented on July 19, 2024

Thanks. So can we save this data directly in db?

from piicatcher.

vrajat avatar vrajat commented on July 19, 2024

from piicatcher.

jayeshagwan1 avatar jayeshagwan1 commented on July 19, 2024

Thanks ! So we will have these options in the similar way as config file ?

from piicatcher.

jayeshagwan1 avatar jayeshagwan1 commented on July 19, 2024

Yes: https://tokern.io/docs/piicatcher/2-usage You can use --orm-host and other options. FYI: I am going to change those option names to "catalog-". For example, catalog-host etc. Right now, MySQL is supported

On Tue, Jan 21, 2020 at 12:10 PM jayeshagwan1 @.
**> wrote: Thanks. So can we save this data directly in db? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#52?email_source=notifications&email_token=AAMP7GSCJI47OUAOBQMFVVDQ62KGXA5CNFSM4KJOA4P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJOU3SI#issuecomment-576540105>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMP7GSCOAQRGJ2INZ7JSZLQ62KGXANCNFSM4KJOA4PQ .

Can you provide the exact command for this ? So I have 2 config files 1 for connecting db and read the db and other for inserting into db.

from piicatcher.

vrajat avatar vrajat commented on July 19, 2024

Single config file

 catalog_host=".."
 catalog_port="..."
 catalog_user="..."
 catalog_password="..."

[db]
...

Also can you give me feedback on the docs ?

https://tokern.io/docs/piicatcher/2-usage#configuration-file
https://tokern.io/docs/piicatcher/3-catalog#database

from piicatcher.

jayeshagwan1 avatar jayeshagwan1 commented on July 19, 2024

Docs look good, just one observation. In docs its hyphen eg catalog-host and in above response you mentioned catalog_host.
Also if we can add sample of command for each type, it would help.

from piicatcher.

vrajat avatar vrajat commented on July 19, 2024

from piicatcher.

jayeshagwan1 avatar jayeshagwan1 commented on July 19, 2024

Can we add one more column for Pii type ?

image

In the above screenshot, ACQUISITION_DATE if of which type of PII.

from piicatcher.

vrajat avatar vrajat commented on July 19, 2024

from piicatcher.

jayeshagwan1 avatar jayeshagwan1 commented on July 19, 2024

Aaah. Ok

from piicatcher.

jayeshagwan1 avatar jayeshagwan1 commented on July 19, 2024

@vrajat Can we keep output consistent for all ? In db, json file shows
image

If we try file type then response is:
image

So in file type we are not able to identify which column has PII data and what type of PII data. If file output would also show same as db one, it would be better to understand

from piicatcher.

vrajat avatar vrajat commented on July 19, 2024

from piicatcher.

vrajat avatar vrajat commented on July 19, 2024

I'll be removing support for files.

from piicatcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.