CSS not correct for enlarging the image on click about ember-cli-tutorial-style HOT 6 CLOSED

I ran ember install ember-cli-tutorial-style and it works (tested both in Firefox 47 and Chromium 51).

from ember-cli-tutorial-style.

Thanks for reporting. I'll take a look this week

from ember-cli-tutorial-style.

Tried on chrome, firefox, safari, and brave... seems to be working. What browser are you seeing this on? is your markup different than the tutorial?

from ember-cli-tutorial-style.

I get the same issue on Firefox 47 and Chromium 51.

.listing .wide {
  max-width: 100%;
  position: relative;
  z-index: 999;
}

.listing a.image {
  max-width: 150px;
  display: block;
}

The second selector is more specific and therefore wins (overriding max-width).

Apart from the previously mentioned fix this also works (making the first selector more specific):

.listing a.image.wide {
  max-width: 100%;
  position: relative;
  z-index: 999;
}

.listing a.image {
  max-width: 150px;
  display: block;
}

from ember-cli-tutorial-style.

Ok. Thanks for investigating the fix. Do either of you mind submitting a pr?
On Tue, Jul 19, 2016 at 6:47 AM Omar K. [email protected] wrote:

I get the same issue on Firefox 47 and Chromium 51.

.listing .wide {
max-width: 100%;
position: relative;
z-index: 999;
}
.listing a.image {
max-width: 150px;
display: block;
}

The second selector is more specific and therefore wins (overriding
max-width).

Apart from the previously mentioned fix this also works (making the first
selector more specific):

.listing a.image.wide {
max-width: 100%;
position: relative;
z-index: 999;
}
.listing a.image {
max-width: 150px;
display: block;
}

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADcR50rz_iuu858uHtZwEhL5YCYleQt_ks5qXKtQgaJpZM4JI5Y2
.

from ember-cli-tutorial-style.

@omarkohl @d3chapma I've updated the addon to 0.0.5. Update your project to the new addon version and let me know if the fix resolves it. (make sure you re-run ember install ember-cli-tutorial-style so that it runs the blueprint and replaces the vendor css.)

from ember-cli-tutorial-style.