Comments (8)
I confirm, this is a verified bug.
(sorry, had to.. it's definitely a bug though :)
from verify.
That'll teach me to code when I'm tired! Cheers, fixed :)
from verify.
Thanks for fixing.
Would probably have been better to add a separate migration file for the patch otherwise the database on existing installations wouldn't be patched
from verify.
I wanted to do that, but I couldn't see a way to alter columns using the Schema class. I've now realised I can. I'll change it.
from verify.
Hmm, it seems the only way I can do this using the Schema class is to drop then create the column, which of course would lose all the data in the initial column.
I think, as the bundle is still young and the install base probably very low, I'll just leave the edited initial migration file. I'm sure the few people that have installed it can just change the column themselves.
I'll leave it a few days to see if anyone has any other suggestions. If not, I might just close the issue.
from verify.
@Toddish Yes, I agree, probably not worth the hassle at this early stage of the development :)
from verify.
Um.. I hate to say it, but I'm building an app using this auth system. And I gotta say, if this is how you guys are going to fix bugs by dropping databases, I don't think I'll continue using this system. I love it's simplicity, but you have NO documentation stating this "fix" in the readme for users who are upgrading versions.
That's not what I would call best practice. If you're going to go the short and easy fix route at least document it for your users in a changelog or something.
from verify.
That's a fair point. As stated above though, the fix would be different if I could alter columns using the Schema class.
And to be honest, the fix was made days after the bundle was released, and I didn't think many people would even be using it.
I'll be adding a changelog in the next few days when I release the next update, along with upgrade instructions. I'll also be adding more substantial docs on my site eventually.
For now, changing one column in a database isn't exactly a big deal :)
from verify.
Related Issues (20)
- Auth::is('Role name') always returns false for logged in user with that role.
- Prefix for db tables HOT 3
- General error: 1 near "CONSTRAINT": syntax error HOT 3
- General error: 1005 at artisan migrate verify HOT 8
- got an error similar to the other issues HOT 1
- Initial MySQL migration error HOT 1
- No outstanding migrations. HOT 4
- Documentation Incorrect HOT 3
- Example HOT 1
- Username or Email as Unique HOT 1
- Retrieve logged user without passing id HOT 1
- Column description should be nullable HOT 1
- Provide value for timestamps HOT 1
- Change role/user relationship to one-to-many
- New user with existing Role HOT 1
- General error: 1 near "CONSTRAINT": syntax error when using sqlite
- Grab user with model HOT 2
- Access model in models folder HOT 3
- updating user doesn't hash the password HOT 2
- Usage in task
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verify.