Comments (3)
I committed a fix, it was an easy one, I just needed to check if the node existed in the body before trying to remove it.
Your use case is one I haven't tested before. You are using the same "custom popover" in multiple places, it is a valid use case, I just never thought about it.
Thank you very much for reporting the issue, I have created a new release with the fix.
from aurelia-bootstrap.
Hello there.
I have not been able to reproduce the issue. The code is already checking if the popover exists before trying to remove it, here.
I created a page with some tabs, and I added popovers to two tabs. Then I proceed to navigate out of the page, the popovers were removed without a problem.
Would you please provide more information into how reproduce the issue, and please make sure you are running in the latest release.
Thank you for using Aurelia Bootstrap :)
from aurelia-bootstrap.
Hello tochoromero, sorry for the delay.
I did a sample project for you to look at if you find the time.
To replicate the behaviour I get in my real app you just press the reload button in the left hand list.
https://github.com/magnus-hansson/aurelia-cli-contact-manager-custom-poop
I did try to change the detached event to check for the existance of the this.popover before removeChild was run but even though it looked like it could work, after I did the reload I didnt get any popovers at all.
Thanks for your great work.
from aurelia-bootstrap.
Related Issues (20)
- Incorrect way of calling global options in the docs HOT 1
- Tooltip stays if the button gets disabled HOT 1
- How to inject variables into custom popovers? HOT 7
- Label "for" not working (not passing focus) to aubs-typeahead HOT 2
- Pagination: TotalItemsChange and PageSizeChanged setting currentPage to 1
- Support more tooltip positions HOT 3
- Installation Problem...
- Add Webpack support
- Failure to reattach popvers (this.viewModel.attached is not a function) HOT 1
- Responsive sizing for pagination bar based on container HOT 1
- Browser autofill is popping up in front of dropdown HOT 6
- Support bootstrap v4 beta changes HOT 5
- Typeahead: async data and custom-entry
- Write Documentation for Typehead custom template
- typeahead adds showClass to wrong element HOT 2
- Typeahead initial value HOT 3
- Add Item HOT 1
- Getting Aurelia CLI going with Aurelia-bootstrap as of 2018
- Is this project abandoned? HOT 3
- I know this project is not maintained anymore, but is the documentation still available? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aurelia-bootstrap.